You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/06/01 01:10:12 UTC
Re: Review Request: Added a statistics abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5266/#review8275
-----------------------------------------------------------
Ship it!
src/statistics/statistics.hpp
<https://reviews.apache.org/r/5266/#comment17900>
s/declarations/declaration/
src/statistics/statistics.hpp
<https://reviews.apache.org/r/5266/#comment17901>
s/witin/within/
src/statistics/statistics.hpp
<https://reviews.apache.org/r/5266/#comment17899>
ws
src/statistics/statistics.cpp
<https://reviews.apache.org/r/5266/#comment17902>
why not cfloat instead?
src/statistics/statistics.cpp
<https://reviews.apache.org/r/5266/#comment17903>
woah..whats this?
src/statistics/statistics.cpp
<https://reviews.apache.org/r/5266/#comment17904>
shouldnt this be the last value in the series instead of Clock::now()?
- Vinod
On 2012-05-31 19:17:10, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5266/
> -----------------------------------------------------------
>
> (Updated 2012-05-31 19:17:10)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 96cb4c6
> src/common/seconds.hpp 5ae088a
> src/statistics/statistics.hpp PRE-CREATION
> src/statistics/statistics.cpp PRE-CREATION
> src/tests/statistics_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5266/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>