You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2021/05/08 16:58:36 UTC
Review Request 73340: ATLAS-4274: Non matching relation are created
via bulk import
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
Bugs: ATLAS-4274
https://issues.apache.org/jira/browse/ATLAS-4274
Repository: atlas
Description
-------
ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
Diffs
-----
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java ee306c6b0
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
Diff: https://reviews.apache.org/r/73340/diff/1/
Testing
-------
Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/#review222984
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On May 12, 2021, 1 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73340/
> -----------------------------------------------------------
>
> (Updated May 12, 2021, 1 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
>
>
> Bugs: ATLAS-4274
> https://issues.apache.org/jira/browse/ATLAS-4274
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
>
>
> Diff: https://reviews.apache.org/r/73340/diff/3/
>
>
> Testing
> -------
>
> Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/
-----------------------------------------------------------
(Updated May 13, 2021, 5:42 p.m.)
Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
Bugs: ATLAS-4274
https://issues.apache.org/jira/browse/ATLAS-4274
Repository: atlas
Description
-------
ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
Diff: https://reviews.apache.org/r/73340/diff/4/
Changes: https://reviews.apache.org/r/73340/diff/3-4/
Testing
-------
Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/
-----------------------------------------------------------
(Updated May 12, 2021, 8 p.m.)
Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
Bugs: ATLAS-4274
https://issues.apache.org/jira/browse/ATLAS-4274
Repository: atlas
Description
-------
ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
Diff: https://reviews.apache.org/r/73340/diff/3/
Changes: https://reviews.apache.org/r/73340/diff/2-3/
Testing
-------
Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/#review222973
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1164 (patched)
<https://reviews.apache.org/r/73340/#comment312141>
updateGlossaryTermIfNeeded => updateGlossaryTermRelations
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Line 69 (original), 69 (patched)
<https://reviews.apache.org/r/73340/#comment312142>
glossaryNameGuidCacheForImport => glossaryNameGuidCache
glossaryTermOrderDuringImport => glossaryTermOrderCache
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 71 (patched)
<https://reviews.apache.org/r/73340/#comment312143>
glossaryTermNeedLoadForRelationsUpdate => glossaryTermQNameGuidCache
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 665 (patched)
<https://reviews.apache.org/r/73340/#comment312139>
glossaryTermToBeUpdated => updatedGlossaryTerm
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 668 (patched)
<https://reviews.apache.org/r/73340/#comment312140>
glossaryTermAtGraphDB => glossaryTermFromDB
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 842 (patched)
<https://reviews.apache.org/r/73340/#comment312144>
probably longest method name seen in Atlas code :)
consider renaming to: cacheRelatedTermQNameGuid()
- Sarath Subramanian
On May 10, 2021, 12:52 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73340/
> -----------------------------------------------------------
>
> (Updated May 10, 2021, 12:52 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
>
>
> Bugs: ATLAS-4274
> https://issues.apache.org/jira/browse/ATLAS-4274
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
>
>
> Diff: https://reviews.apache.org/r/73340/diff/2/
>
>
> Testing
> -------
>
> Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/
-----------------------------------------------------------
(Updated May 10, 2021, 7:52 p.m.)
Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
Bugs: ATLAS-4274
https://issues.apache.org/jira/browse/ATLAS-4274
Repository: atlas
Description
-------
ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
Diff: https://reviews.apache.org/r/73340/diff/2/
Changes: https://reviews.apache.org/r/73340/diff/1-2/
Testing
-------
Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
Thanks,
Sidharth Mishra
Re: Review Request 73340: ATLAS-4274: Non matching relation are
created via bulk import
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/#review222958
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 428 (patched)
<https://reviews.apache.org/r/73340/#comment312131>
avoid adding copy logic here to model class (AtlasGlossaryTerm) consider moving to GlossaryTermUtils
- Sarath Subramanian
On May 8, 2021, 9:58 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73340/
> -----------------------------------------------------------
>
> (Updated May 8, 2021, 9:58 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry and Sarath Subramanian.
>
>
> Bugs: ATLAS-4274
> https://issues.apache.org/jira/browse/ATLAS-4274
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4274: Added code to load some terms from graph DB if needed during glossary import
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java ee306c6b0
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 73217ded3
> repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 553d3d0a6
>
>
> Diff: https://reviews.apache.org/r/73340/diff/1/
>
>
> Testing
> -------
>
> Manually tested and confirmed its working as expected. org.apache.atlas.glossary.GlossaryServiceTest UTs are passing.
>
>
> Thanks,
>
> Sidharth Mishra
>
>