[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6432: [TE] endpoint - harleyjj/rca - add forecast, upper, lower, and yoXy t…

[GitBox <gi...@apache.org>]

harleyjj commented on a change in pull request #6432:
URL: https://github.com/apache/incubator-pinot/pull/6432#discussion_r556229575



##########
File path: thirdeye/thirdeye-dashboard/src/main/java/org/apache/pinot/thirdeye/dashboard/resources/v2/RootCauseMetricResource.java
##########
@@ -284,11 +288,54 @@ public double getAggregate(@ApiParam(value = "metric urn", required = true) @Que
     urns = ResourceUtils.parseListParams(urns);
     offsets = ResourceUtils.parseListParams(offsets);
     List<MetricSlice> slices = new ArrayList<>();
+    List<String> forecastOffsets = Arrays.asList(OFFSET_FORECAST, OFFSET_LOWER, OFFSET_UPPER);
+    Map<Pair<String, String>, Double> offsetToForecastAggregate = new HashMap<>();
+
+    if(offsets.contains(OFFSET_FORECAST)) {

Review comment:
       Good question.  At the moment, we are only serving upper and lower bounds in the case of forecast.  If someone requested the upper or lower bound and not the forecast, it would call the forecast endpoint (if I add upper and lower here).  Do we want that to happen?  As it's written now, it will populate upper and lower values with NaN if forecast isn't present.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org