[GitHub] [incubator-baremaps] github-code-scanning[bot] commented on a diff in pull request #694: Fix null pointer exception related to bounds

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #694:
URL: https://github.com/apache/incubator-baremaps/pull/694#discussion_r1227707462


##########
baremaps-core/src/main/java/org/apache/baremaps/tilestore/postgres/PostgresTileStore.java:
##########
@@ -239,7 +239,7 @@
   }
 
   /** This operation is not supported. */
-  public void write(TileCoord tileCoord, ByteBuffer blob) {
+  public void put(TileCoord tileCoord, ByteBuffer blob) {

Review Comment:
   ## Missing Override annotation
   
   This method overrides [TileStore.put](1); it is advisable to add an Override annotation.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/669)



##########
baremaps-benchmark/src/main/java/org/apache/baremaps/benchmarks/MBTilesBenchmark.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
+ * in compliance with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package org.apache.baremaps.benchmarks;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+import org.apache.baremaps.tilestore.TileCoord;
+import org.apache.baremaps.tilestore.TileStoreException;
+import org.apache.baremaps.tilestore.mbtiles.MBTiles;
+import org.apache.baremaps.workflow.tasks.ExportVectorTiles;
+import org.openjdk.jmh.annotations.*;
+import org.openjdk.jmh.runner.Runner;
+import org.openjdk.jmh.runner.RunnerException;
+import org.openjdk.jmh.runner.options.Options;
+import org.openjdk.jmh.runner.options.OptionsBuilder;
+
+@State(Scope.Benchmark)
+@OutputTimeUnit(TimeUnit.MILLISECONDS)
+@Fork(value = 1, warmups = 1)
+public class MBTilesBenchmark {
+
+  public Random random = new Random(0);
+
+  @Param({"10", "100", "1000"})
+  public int iterations;
+
+  private MBTiles mbTiles;
+
+  @Setup
+  public void setup() throws IOException, TileStoreException {
+    var sqliteFile = File.createTempFile("baremaps", ".sqlite");

Review Comment:
   ## Local information disclosure in a temporary directory
   
   Local information disclosure vulnerability due to use of file readable by other local users.
   
   [Show more details](https://github.com/apache/incubator-baremaps/security/code-scanning/670)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org