You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/10/01 18:18:51 UTC
[GitHub] [incubator-hudi] bvaradar commented on a change in pull request
#915: [HUDI-268] Shade and relocate Avro dependency in hadoop-mr-bundle
bvaradar commented on a change in pull request #915: [HUDI-268] Shade and relocate Avro dependency in hadoop-mr-bundle
URL: https://github.com/apache/incubator-hudi/pull/915#discussion_r330203199
##########
File path: packaging/hudi-hadoop-mr-bundle/pom.xml
##########
@@ -77,6 +79,10 @@
<pattern>com.esotericsoftware.minlog.</pattern>
<shadedPattern>org.apache.hudi.com.esotericsoftware.minlog.</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.apache.avro.</pattern>
+ <shadedPattern>org.apache.hudi.org.apache.avro.</shadedPattern>
Review comment:
Add one more property and use it here.
mr.bundle.avro.shade.prefix
<shadedPattern>${mr.bundle.avro.shade.prefix}org.apache.avro.</shadedPattern>
The default value should be empty string ""
<mr.bundle.avro.shade.prefix></mr.bundle.avro.shade.prefix>
and in the profile activation step (shade-avro), set it to
<mr.bundle.avro.shade.prefix>org.apache.hudi.</mr.bundle.avro.shade.prefix>
Can you try this setup and check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services