You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/25 12:11:18 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #11651: [Feature][Task Plugin] Support hive cli task plugin
EricGao888 opened a new pull request, #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651
## Purpose of the pull request
* Add `Hive Cli` task plugin
* Currently DS only supports running hive sql through jdbc. This PR adds hive cli task plugin to enable users to run hive sql using hive client for stability in prod environment.
* In some companies, pure `shell` tasks are banned for security reasons. It will be better to provide such a `hive Cli` task.
* This PR closes: #11261
## Brief change log
* Already described above.
* Will add docs in the following commits.
## Verify this pull request
* Verified by UTs and manual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1231061835
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [52.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1231090467
> > > What if hive with kerberos? Most companies will enable kerberos in the production environment.
> >
> >
> > @zhuxt2015 Good question. AFAIK, currently DS task plugins do not support `kerberos` except `SQL tasks with datasource`. I've added instructions in docs about how to choose between `hive datasource` and `hive cli task plugin` for different scenarios. If they enable `kerberos`, they could use `SQL tasks with hive datasource` to connect to `hiveserver2` with `jdbc` at this moment.
> > However, it will be great if other task plugins like `spark task plugin`, `hive cli task plugin`, etc. could support `kerberos` in the future. May I ask whether you have any suggestions or ideas on how to do it? Thanks.
>
> 1. hive command bypasses permission management, In most cases it will be disabled in a production environment。
> 2. If you have to use hive command with kerberos be enabled. execute `kinit -kt <keytab path> <principal> ` before execute hive command ,
@zhuxt2015 Thanks for the information.
1. For the first point, we have the same situation with `spark-submit`, `spark-sql`, `flink run`, etc. besides `hive` considering permissions. We could abstract this and make it apply to all those task plugins. Would you like to submit an issue and give a shot? @zhuxt2015
2. `HiveServer2` is mainly used for `ad-hoc` query. In production, `HiveServer2` is not a good practice for scheduled big data tasks. We have seen several cases of production failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1229813432
BTW, we might combine `spark task plugin` with `spark datasource` and `hive cli task plugin` with `hive datasource` when doing #10283 so that users could manage similar tasks in the same plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r957918404
##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-hive-cli.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { reactive } from 'vue'
+import * as Fields from '../fields/index'
+import type { IJsonItem, INodeData, ITaskData } from '../types'
+
+export function useHiveCli({
+ projectCode,
+ from = 0,
+ readonly,
+ data
+ }: {
+ projectCode: number
Review Comment:
We will add a husky to lint code later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956976608
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -644,6 +644,12 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ hive_cli_task_execution_type: 'Hive Cli 任务类型',
+ hive_cli_task_execution_type_tips: '请选择您的Hive Cli任务类型',
+ hive_sql_script: 'Hive SQL 脚本',
+ hive_sql_script_tips: '请填写您的Hive SQL脚本',
Review Comment:
You mean `hive_sql_script_tips`? I will remove it in the next commit.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -644,6 +644,12 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ hive_cli_task_execution_type: 'Hive Cli 任务类型',
+ hive_cli_task_execution_type_tips: '请选择您的Hive Cli任务类型',
Review Comment:
Sure will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1227282816
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [52.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuxt2015 commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
zhuxt2015 commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1231080400
> > What if hive with kerberos? Most companies will enable kerberos in the production environment.
>
> @zhuxt2015 Good question. AFAIK, currently DS task plugins do not support `kerberos` except `SQL tasks with datasource`. I've added instructions in docs about how to choose between `hive datasource` and `hive cli task plugin` for different scenarios. If they enable `kerberos`, they could use `SQL tasks with hive datasource` to connect to `hiveserver2` with `jdbc` at this moment.
>
> However, it will be great if other task plugins like `spark task plugin`, `hive cli task plugin`, etc. could support `kerberos` in the future. May I ask whether you have any suggestions or ideas on how to do it? Thanks.
1. hive command bypasses permission management, In most cases it will be disabled in a production environment。
2. If you have to use hive command with kerberos be enabled. execute `kinit -kt <keytab path> <principal> ` before execute hive command ,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956976046
##########
dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts:
##########
@@ -658,5 +664,10 @@ export function formatModel(data: ITaskData) {
if (data.taskParams?.jobType) {
params.isCustomTask = data.taskParams.jobType === 'CUSTOM'
}
+
+ if (data.taskParams?.type) {
+ params.type = data.taskParams.type
Review Comment:
Sure I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r957062007
##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-hive-cli.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { reactive } from 'vue'
+import * as Fields from '../fields/index'
+import type { IJsonItem, INodeData, ITaskData } from '../types'
+
+export function useHiveCli({
+ projectCode,
+ from = 0,
+ readonly,
+ data
+ }: {
+ projectCode: number
Review Comment:
run 'npm run lint'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 merged pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 merged PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r957361921
##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-hive-cli.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { reactive } from 'vue'
+import * as Fields from '../fields/index'
+import type { IJsonItem, INodeData, ITaskData } from '../types'
+
+export function useHiveCli({
+ projectCode,
+ from = 0,
+ readonly,
+ data
+ }: {
+ projectCode: number
Review Comment:
@Amy0104 I ran `npm run lint` under `dolphinscheduler-ui` directory, thus some other files are reformatted as well. PTAL when available, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Amy0104 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
Amy0104 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956969619
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-hive-cli.ts:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { useI18n } from 'vue-i18n'
+import {useCustomParams, useResources} from '.'
+import type { IJsonItem } from '../types'
+
+export function useHiveCli(model: { [field: string]: any }): IJsonItem[] {
+ const { t } = useI18n()
+
+ return [
+ {
+ type: 'select',
+ field: 'hiveCliTaskExecutionType',
+ span: 12,
+ name: t('project.node.hive_cli_task_execution_type'),
+ options: HIVE_CLI_TASK_EXECUTION_TYPES,
+ },
+ {
+ type: 'editor',
+ field: 'hiveSqlScript',
+ name: t('project.node.hive_sql_script'),
+ props: {
+ language: 'sql'
+ }
+ },
+ {
+ type: 'input',
+ field: 'hiveCliOptions',
+ name: t('project.node.hive_cli_options'),
+ props: {
+ placeholder: t('project.node.hive_cli_options')
Review Comment:
It's better to use the 'hive_cli_options_tips' here.
##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-hive-cli.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { reactive } from 'vue'
+import * as Fields from '../fields/index'
+import type { IJsonItem, INodeData, ITaskData } from '../types'
+
+export function useHiveCli({
+ projectCode,
+ from = 0,
+ readonly,
+ data
+ }: {
+ projectCode: number
Review Comment:
It's better to format the code by eslint.
##########
dolphinscheduler-ui/src/views/projects/task/components/node/format-data.ts:
##########
@@ -658,5 +664,10 @@ export function formatModel(data: ITaskData) {
if (data.taskParams?.jobType) {
params.isCustomTask = data.taskParams.jobType === 'CUSTOM'
}
+
+ if (data.taskParams?.type) {
+ params.type = data.taskParams.type
Review Comment:
It seems that the type doesn't need to be reassigned here.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -644,6 +644,12 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ hive_cli_task_execution_type: 'Hive Cli 任务类型',
+ hive_cli_task_execution_type_tips: '请选择您的Hive Cli任务类型',
+ hive_sql_script: 'Hive SQL 脚本',
+ hive_sql_script_tips: '请填写您的Hive SQL脚本',
Review Comment:
This seems not to be used too.
##########
dolphinscheduler-ui/src/locales/zh_CN/project.ts:
##########
@@ -644,6 +644,12 @@ export default {
zeppelin_parameters_tips: '请输入zeppelin dynamic form参数',
zeppelin_rest_endpoint: 'zeppelinRestEndpoint',
zeppelin_rest_endpoint_tips: '请输入zeppelin server的rest endpoint',
+ hive_cli_task_execution_type: 'Hive Cli 任务类型',
+ hive_cli_task_execution_type_tips: '请选择您的Hive Cli任务类型',
Review Comment:
This seems not to be used, same as the en_US.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956977183
##########
dolphinscheduler-ui/src/views/projects/task/components/node/tasks/use-hive-cli.ts:
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { reactive } from 'vue'
+import * as Fields from '../fields/index'
+import type { IJsonItem, INodeData, ITaskData } from '../types'
+
+export function useHiveCli({
+ projectCode,
+ from = 0,
+ readonly,
+ data
+ }: {
+ projectCode: number
Review Comment:
May I ask whether how I could format it with `eslint`? Is there any command I could use to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1231062441
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [52.4% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1227283197
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [52.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1229824817
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [55.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956976233
##########
dolphinscheduler-ui/src/views/projects/task/components/node/fields/use-hive-cli.ts:
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import { useI18n } from 'vue-i18n'
+import {useCustomParams, useResources} from '.'
+import type { IJsonItem } from '../types'
+
+export function useHiveCli(model: { [field: string]: any }): IJsonItem[] {
+ const { t } = useI18n()
+
+ return [
+ {
+ type: 'select',
+ field: 'hiveCliTaskExecutionType',
+ span: 12,
+ name: t('project.node.hive_cli_task_execution_type'),
+ options: HIVE_CLI_TASK_EXECUTION_TYPES,
+ },
+ {
+ type: 'editor',
+ field: 'hiveSqlScript',
+ name: t('project.node.hive_sql_script'),
+ props: {
+ language: 'sql'
+ }
+ },
+ {
+ type: 'input',
+ field: 'hiveCliOptions',
+ name: t('project.node.hive_cli_options'),
+ props: {
+ placeholder: t('project.node.hive_cli_options')
Review Comment:
Sure, will fix it in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1230284524
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [55.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r956909099
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-hivecli/src/main/java/org/apache/dolphinscheduler/plugin/task/hivecli/HiveCliConstants.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.hivecli;
+
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public class HiveCliConstants {
+
+ public static final String TYPE_SCRIPT = "SCRIPT";
+
+ public static final String TYPE_FILE = "FILE";
+
+ public static final String HIVE_CLI_EXECUTE_FILE = "hive -f";
+
+ public static final String HIVE_CLI_EXECUTE_SCRIPT = "hive -e \"%s\"";
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1229823524
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [55.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1230284183
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11651)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11651&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list) [55.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11651&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhuxt2015 commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
zhuxt2015 commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1229429801
What if hive with kerberos? Most companies will enable kerberos in the production environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#issuecomment-1229794898
> What if hive with kerberos? Most companies will enable kerberos in the production environment.
@zhuxt2015 Good question. AFAK, currently DS task plugins does not support `kerberos` except `SQL tasks with datasource`. I've added instructions in docs about how to choose between `hive datasource` and `hive cli task plugin` for different scenarios.
However, it will be great if other task plugins like `spark task plugin`, `hive cli task plugin`, etc. could support `kerberos` in the future. May I ask whether you have any suggestions or ideas on how to do it? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11651: [Feature][Task Plugin] Support hive cli task plugin
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #11651:
URL: https://github.com/apache/dolphinscheduler/pull/11651#discussion_r954984586
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-hivecli/src/main/java/org/apache/dolphinscheduler/plugin/task/hivecli/HiveCliConstants.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.hivecli;
+
+import lombok.experimental.UtilityClass;
+
+@UtilityClass
+public class HiveCliConstants {
+
+ public static final String TYPE_SCRIPT = "SCRIPT";
+
+ public static final String TYPE_FILE = "FILE";
+
+ public static final String HIVE_CLI_EXECUTE_FILE = "hive -f";
+
+ public static final String HIVE_CLI_EXECUTE_SCRIPT = "hive -e \"%s\"";
Review Comment:
I think we can provide `-v` and `--hiveconf` as options for users to choose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org