You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/06/09 13:53:38 UTC
Review Request 59629: HIVE-14745: Remove jira user/password from
profiles by using another command to submit results to jira
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/
-----------------------------------------------------------
Review request for hive, Sergio Pena and Siddharth Seth.
Bugs: HIVE-14745
https://issues.apache.org/jira/browse/HIVE-14745
Repository: hive-git
Description
-------
Added the ability to write data needed for the jira comment into json.
Refactored the TestStatus response to contain the generated jira comment.
Refactored the PTestClient to take the jira comment from the last TestStatus response which is either a success or a failure and post it to the Jira Service.
Diffs
-----
testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/common/JiraCommentPoster.java PRE-CREATION
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/response/TestStatus.java 7dfadb42edbb8526b169d3034e01d0e8e8739fdf
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java 2f96ad03023e9f51d44d203f34edd04183605a22
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/Test.java 7fbabd96d8c9a443bb5cfd2defe7a10510cf9a15
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java ff1dbd4bafaba9a0e88321c6507a47bbe0421833
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java e584f9c105fa134e3e267d6c6817d441b4c6b249
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/client/TestPTestClient.java PRE-CREATION
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3
Diff: https://reviews.apache.org/r/59629/diff/1/
Testing
-------
Added unit tests for PTestClient and JiraService.
Ran a test with a heavily dumbed down CloudExecutionContextProvider that would create the drowns on the local machine isntead of a cloud povider to test integration between PTestClient and the WebService.
Thanks,
Barna Zsombor Klara
Re: Review Request 59629: HIVE-14745: Remove jira user/password from
profiles by using another command to submit results to jira
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
> On June 13, 2017, 10:20 a.m., Peter Vary wrote:
> > testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
> > Lines 92-93 (original), 120-121 (patched)
> > <https://reviews.apache.org/r/59629/diff/1/?file=1746782#file1746782line120>
> >
> > nit: If there is any useful comment, please changed the order back to the original :D
The HttpClient is no longer final, so I took it our from the list of final variables.
- Barna Zsombor
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/#review177723
-----------------------------------------------------------
On June 13, 2017, 3 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59629/
> -----------------------------------------------------------
>
> (Updated June 13, 2017, 3 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14745
> https://issues.apache.org/jira/browse/HIVE-14745
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the ability to write data needed for the jira comment into json.
> Refactored the TestStatus response to contain the generated jira comment.
> Refactored the PTestClient to take the jira comment from the last TestStatus response which is either a success or a failure and post it to the Jira Service.
>
>
> Diffs
> -----
>
> testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/common/JiraCommentPoster.java PRE-CREATION
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/response/TestStatus.java 7dfadb42edbb8526b169d3034e01d0e8e8739fdf
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java 2f96ad03023e9f51d44d203f34edd04183605a22
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/Test.java 7fbabd96d8c9a443bb5cfd2defe7a10510cf9a15
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java ff1dbd4bafaba9a0e88321c6507a47bbe0421833
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java e584f9c105fa134e3e267d6c6817d441b4c6b249
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/client/TestPTestClient.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3
>
>
> Diff: https://reviews.apache.org/r/59629/diff/2/
>
>
> Testing
> -------
>
> Added unit tests for PTestClient and JiraService.
> Ran a test with a heavily dumbed down CloudExecutionContextProvider that would create the drowns on the local machine isntead of a cloud povider to test integration between PTestClient and the WebService.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 59629: HIVE-14745: Remove jira user/password from
profiles by using another command to submit results to jira
Posted by Peter Vary <pv...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/#review177723
-----------------------------------------------------------
Thanks Zsombor for the patch!
Only one useful comment and some nits.
Thanks,
Peter
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
Lines 92-93 (original), 120-121 (patched)
<https://reviews.apache.org/r/59629/#comment251445>
nit: If there is any useful comment, please changed the order back to the original :D
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
Lines 299 (patched)
<https://reviews.apache.org/r/59629/#comment251446>
nit: If there is any useful comment, could you please move it back to the original position?
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
Line 321 (original), 383 (patched)
<https://reviews.apache.org/r/59629/#comment251447>
nit: why is the order changed?
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
Lines 43 (patched)
<https://reviews.apache.org/r/59629/#comment251448>
nit: Do we need this import?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
Lines 41-45 (patched)
<https://reviews.apache.org/r/59629/#comment251449>
nit: If there is any useful comments could you please remove the reordering the imports?
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java
Lines 170 (patched)
<https://reviews.apache.org/r/59629/#comment251450>
nit: Is it important that it is a sorted set?
- Peter Vary
On June 9, 2017, 1:53 p.m., Barna Zsombor Klara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59629/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:53 p.m.)
>
>
> Review request for hive, Sergio Pena and Siddharth Seth.
>
>
> Bugs: HIVE-14745
> https://issues.apache.org/jira/browse/HIVE-14745
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Added the ability to write data needed for the jira comment into json.
> Refactored the TestStatus response to contain the generated jira comment.
> Refactored the PTestClient to take the jira comment from the last TestStatus response which is either a success or a failure and post it to the Jira Service.
>
>
> Diffs
> -----
>
> testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/common/JiraCommentPoster.java PRE-CREATION
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/response/TestStatus.java 7dfadb42edbb8526b169d3034e01d0e8e8739fdf
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java 2f96ad03023e9f51d44d203f34edd04183605a22
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/Test.java 7fbabd96d8c9a443bb5cfd2defe7a10510cf9a15
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java ff1dbd4bafaba9a0e88321c6507a47bbe0421833
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java e584f9c105fa134e3e267d6c6817d441b4c6b249
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/client/TestPTestClient.java PRE-CREATION
> testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3
>
>
> Diff: https://reviews.apache.org/r/59629/diff/1/
>
>
> Testing
> -------
>
> Added unit tests for PTestClient and JiraService.
> Ran a test with a heavily dumbed down CloudExecutionContextProvider that would create the drowns on the local machine isntead of a cloud povider to test integration between PTestClient and the WebService.
>
>
> Thanks,
>
> Barna Zsombor Klara
>
>
Re: Review Request 59629: HIVE-14745: Remove jira user/password from
profiles by using another command to submit results to jira
Posted by Barna Zsombor Klara <zs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59629/
-----------------------------------------------------------
(Updated June 13, 2017, 3 p.m.)
Review request for hive, Sergio Pena and Siddharth Seth.
Changes
-------
Updated based on Peter's review. Thank you!
Bugs: HIVE-14745
https://issues.apache.org/jira/browse/HIVE-14745
Repository: hive-git
Description
-------
Added the ability to write data needed for the jira comment into json.
Refactored the TestStatus response to contain the generated jira comment.
Refactored the PTestClient to take the jira comment from the last TestStatus response which is either a success or a failure and post it to the Jira Service.
Diffs (updated)
-----
testutils/ptest2/conf/deployed/master-mr2.properties 05c040599172caf9d67c4e27affce12a335dab4b
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java 8e2604d372ac29b94445b269f08423b058308efe
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/common/JiraCommentPoster.java PRE-CREATION
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/response/TestStatus.java 7dfadb42edbb8526b169d3034e01d0e8e8739fdf
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java 2f96ad03023e9f51d44d203f34edd04183605a22
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/Test.java 7fbabd96d8c9a443bb5cfd2defe7a10510cf9a15
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java b2c61f03c5bf5f170894141848c89fc26129115a
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/JIRAService.java ff1dbd4bafaba9a0e88321c6507a47bbe0421833
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 1cdfdb309acd8282e593abd7ed10c87721926c60
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java e584f9c105fa134e3e267d6c6817d441b4c6b249
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/client/TestPTestClient.java PRE-CREATION
testutils/ptest2/src/test/java/org/apache/hive/ptest/api/server/TestTestExecutor.java a4a789b579305d9ed573d8c1fd0b6ce75787d50f
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java b97b890dfe855539de2696788327ba9b4a841ff3
Diff: https://reviews.apache.org/r/59629/diff/2/
Changes: https://reviews.apache.org/r/59629/diff/1-2/
Testing
-------
Added unit tests for PTestClient and JiraService.
Ran a test with a heavily dumbed down CloudExecutionContextProvider that would create the drowns on the local machine isntead of a cloud povider to test integration between PTestClient and the WebService.
Thanks,
Barna Zsombor Klara