[jira] [Commented] (WICKET-4224) DataTable markup : change SPAN to DIV

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440273#comment-13440273 ] 

Martin Grigorov commented on WICKET-4224:
-----------------------------------------

The change is reverted for HeaderToolbar.html because of the reasons explained in WICKET-4710.
If block elements are needed in the headers then the developer has to provide custom markup for the toolbar. 
                
> DataTable markup : change SPAN to DIV
> -------------------------------------
>
>                 Key: WICKET-4224
>                 URL: https://issues.apache.org/jira/browse/WICKET-4224
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.19, 1.5.2
>            Reporter: Pierre Goiffon
>            Assignee: Emond Papegaaij
>             Fix For: 6.0.0-beta1
>
>         Attachments: 0001-WICKET-4224-replace-spans-with-wicket-container-in-D.patch
>
>
> When creating a DataTable, you get SPAN in each TH (HeadersToolbar.html) and TD (DataTable.html). When you have to insert block elements in your TD, it's a problem because a block element can't be inserted in an inline element such as SPAN.
> For exemple the following html is not valid :
> <td><span><div>...
> I'm asking for a change in both HTML to get DIV instead of SPAN.
> Existing apps would only be affected through CSS selectors (and possibly JS), if they have such ones. Must be very rare.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira