You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/02/01 23:53:58 UTC
Review Request 56196: UI changes to resolve discrepancies between
what the stack vs Ambari reports as "live" for NodeManagers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56196/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-19828
https://issues.apache.org/jira/browse/AMBARI-19828
Repository: ambari
Description
-------
Looks like the changes in https://issues.apache.org/jira/browse/AMBARI-9418 was meant to be applied to YARN summary / NodeManagers as well, but that is not happening.
Also, can we put an exclamation icon next to the value when there's a discrepancy (should apply to both HDFS and YARN Summary.)
This way, we can visually notify the user and invite the user to hover over to invoke the tooltip for an explanation.
Diffs
-----
ambari-web/app/messages.js 33a8289
ambari-web/app/templates/main/service/services/yarn.hbs 138742d
ambari-web/app/views/main/service/services/hdfs.js 40fb761
ambari-web/app/views/main/service/services/yarn.js cf8adeb
ambari-web/test/views/main/service/services/hdfs_test.js 06d0e01
ambari-web/test/views/main/service/services/yarn_test.js 9c1cf7a
Diff: https://reviews.apache.org/r/56196/diff/
Testing
-------
Verified Manually.
Ambari-web unit tests pass.
30313 passing (23s)
157 pending
Thanks,
Vivek Ratnavel Subramanian
Re: Review Request 56196: UI changes to resolve discrepancies between
what the stack vs Ambari reports as "live" for NodeManagers
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56196/#review164005
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Feb. 1, 2017, 11:56 p.m., Vivek Ratnavel Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56196/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 11:56 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-19828
> https://issues.apache.org/jira/browse/AMBARI-19828
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Looks like the changes in https://issues.apache.org/jira/browse/AMBARI-9418 was meant to be applied to YARN summary / NodeManagers as well, but that is not happening.
>
>
> Diffs
> -----
>
> ambari-web/app/messages.js 33a8289
> ambari-web/app/templates/main/service/services/yarn.hbs 138742d
> ambari-web/app/views/main/service/services/hdfs.js 40fb761
> ambari-web/app/views/main/service/services/yarn.js cf8adeb
> ambari-web/test/views/main/service/services/hdfs_test.js 06d0e01
> ambari-web/test/views/main/service/services/yarn_test.js 9c1cf7a
>
> Diff: https://reviews.apache.org/r/56196/diff/
>
>
> Testing
> -------
>
> Verified Manually.
> Ambari-web unit tests pass.
> 30313 passing (23s)
> 157 pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>
Re: Review Request 56196: UI changes to resolve discrepancies between
what the stack vs Ambari reports as "live" for NodeManagers
Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56196/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 11:56 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-19828
https://issues.apache.org/jira/browse/AMBARI-19828
Repository: ambari
Description (updated)
-------
Looks like the changes in https://issues.apache.org/jira/browse/AMBARI-9418 was meant to be applied to YARN summary / NodeManagers as well, but that is not happening.
Diffs
-----
ambari-web/app/messages.js 33a8289
ambari-web/app/templates/main/service/services/yarn.hbs 138742d
ambari-web/app/views/main/service/services/hdfs.js 40fb761
ambari-web/app/views/main/service/services/yarn.js cf8adeb
ambari-web/test/views/main/service/services/hdfs_test.js 06d0e01
ambari-web/test/views/main/service/services/yarn_test.js 9c1cf7a
Diff: https://reviews.apache.org/r/56196/diff/
Testing
-------
Verified Manually.
Ambari-web unit tests pass.
30313 passing (23s)
157 pending
Thanks,
Vivek Ratnavel Subramanian