You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/02 19:09:00 UTC
[jira] [Work logged] (BEAM-4711) LocalFileSystem.delete doesn't
support globbing
[ https://issues.apache.org/jira/browse/BEAM-4711?focusedWorklogId=118347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118347 ]
ASF GitHub Bot logged work on BEAM-4711:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/18 19:08
Start Date: 02/Jul/18 19:08
Worklog Time Spent: 10m
Work Description: ryan-williams opened a new pull request #5863: [BEAM-4711] fix globbing in LocalFileSystem.delete
URL: https://github.com/apache/beam/pull/5863
Make `LocalFileSystem.delete` support globs, instead of just literal paths
This makes its behavior consistent with e.g. `GCSFileSystem`
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118347)
Time Spent: 10m
Remaining Estimate: 0h
> LocalFileSystem.delete doesn't support globbing
> -----------------------------------------------
>
> Key: BEAM-4711
> URL: https://issues.apache.org/jira/browse/BEAM-4711
> Project: Beam
> Issue Type: Task
> Components: sdk-py-core
> Affects Versions: 2.5.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I attempted to run {{wordcount_it_test:WordCountIT.test_wordcount_it}} locally with {{DirectRunner}}:
> {code}
> python setup.py nosetests \
> --tests apache_beam.examples.wordcount_it_test:WordCountIT.test_wordcount_it \
> --test-pipeline-options="--output=foo"
> {code}
> It failed in [the {{delete_files}} cleanup command|https://github.com/apache/beam/blob/a58f1ffaafb0e2ebcc73a1c5abfb05a15ec6a84b/sdks/python/apache_beam/examples/wordcount_it_test.py#L64]:
> {code}
> root: WARNING: Retry with exponential backoff: waiting for 11.1454450937 seconds before retrying delete_files because we caught exception: BeamIOError: Delete operation failed with exceptions {'foo/1530557644/results*': IOError(OSError(2, 'No such file or directory'),)}
> Traceback for above exception (most recent call last):
> File "/Users/ryan/c/beam/sdks/python/apache_beam/utils/retry.py", line 184, in wrapper
> return fun(*args, **kwargs)
> File "/Users/ryan/c/beam/sdks/python/apache_beam/testing/test_utils.py", line 136, in delete_files
> FileSystems.delete(file_paths)
> File "/Users/ryan/c/beam/sdks/python/apache_beam/io/filesystems.py", line 282, in delete
> return filesystem.delete(paths)
> File "/Users/ryan/c/beam/sdks/python/apache_beam/io/localfilesystem.py", line 304, in delete
> raise BeamIOError("Delete operation failed", exceptions)
> {code}
> The line:
> {code}
> self.addCleanup(delete_files, [output + '*'])
> {code}
> works as expected in GCS, and deletes a test's output-directory, but it fails in on the local-filesystem, which doesn't expand globs before attempting to delete paths.
> It would be good to make these consistent, presumably by adding glob-support to {{LocalFileSystem}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)