[jira] Commented: (DERBY-3453) The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles creation of SQLException

["Dibyendu Majumdar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575197#action_12575197 ] 

Dibyendu Majumdar commented on DERBY-3453:
------------------------------------------

I am looking at removing EmbedSQLException altogether as suggested by Dan, in favour of SQLException.
It seems that this is feasible.
EmbedSQLException extends SQLException by adding some of the attributes of StandardException - in particular the messageId, and the arguments array.
This will be handled in a uniform manner by always setting a StandardException object as the cause of the SQLException.

As a result of this change, I expect that the classes PublicAPI, o.a.d.impl.jdbc.Util, and EmbedSQLException will be removed.
The SQLExceptionFactory classes are likely to become generic and therefore will get moved to o.a.d.iapi.error.

This change will simplify the exception classes and remove some of the unnecessary dependencies between the modules.



> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles creation of SQLException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3453
>                 URL: https://issues.apache.org/jira/browse/DERBY-3453
>             Project: Derby
>          Issue Type: Sub-task
>            Reporter: Dibyendu Majumdar
>            Assignee: Dibyendu Majumdar
>
> The PublicAPI class should belong to org.apache.derby.iapi.jdbc as it handles creation of SQLException.
> The classes EmbedSQLException and EmbedSQLWarning are better placed in org.apache.derby.iapi.jdbc. These classes are referenced outside the jdbc module.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.