You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/02/19 20:12:53 UTC
Review Request 43775: Fixed bug in appc cache's find logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43775/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Fixed bug in appc cache's find logic.
Diffs
-----
src/slave/containerizer/mesos/provisioner/appc/cache.cpp ff392efb2e0e50ac9ae5e5a8f19b57202439f74e
Diff: https://reviews.apache.org/r/43775/diff/
Testing
-------
Simple integration testing with store.
Thanks,
Jojy Varghese
Re: Review Request 43775: Fixed bug in appc cache's find logic.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43775/#review119951
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Feb. 19, 2016, 7:12 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43775/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:12 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed bug in appc cache's find logic.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/cache.cpp ff392efb2e0e50ac9ae5e5a8f19b57202439f74e
>
> Diff: https://reviews.apache.org/r/43775/diff/
>
>
> Testing
> -------
>
> Simple integration testing with store.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 43775: Fixed bug in appc cache's find logic.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43775/#review119988
-----------------------------------------------------------
Patch looks great!
Reviews applied: [41958, 41959, 43775]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 7:12 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43775/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:12 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed bug in appc cache's find logic.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/cache.cpp ff392efb2e0e50ac9ae5e5a8f19b57202439f74e
>
> Diff: https://reviews.apache.org/r/43775/diff/
>
>
> Testing
> -------
>
> Simple integration testing with store.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 43775: Fixed bug in appc cache's find logic.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43775/#review119934
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 19, 2016, 7:12 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43775/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:12 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed bug in appc cache's find logic.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/appc/cache.cpp ff392efb2e0e50ac9ae5e5a8f19b57202439f74e
>
> Diff: https://reviews.apache.org/r/43775/diff/
>
>
> Testing
> -------
>
> Simple integration testing with store.
>
>
> Thanks,
>
> Jojy Varghese
>
>