You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/22 01:25:17 UTC
[GitHub] [spark] Yikun opened a new pull request, #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
Yikun opened a new pull request, #38341:
URL: https://github.com/apache/spark/pull/38341
### What changes were proposed in this pull request?
Upgrade actions/github-scripts from v3 to v6 and fix notify workflow
### Why are the changes needed?
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
- Since github-script V5, change from `github.*` to `github.rest.*`, but `request`, `paginate` are unchanged.
see also https://github.com/actions/github-script#breaking-changes-in-v5
- Since github-script V6, upgrade node12 to node16
### Does this PR introduce _any_ user-facing change?
No, dev only
### How was this patch tested?
- Due to `pull_request_target`, the current PR is not in effect, we can only do test on local : https://github.com/Yikun/spark/pull/181
Notify works well:
<img width="850" alt="image" src="https://user-images.githubusercontent.com/1736354/197310102-6c709716-8a99-422d-8d38-3f770b6925f0.png">
Update status set to failed as expeceted:
<img width="898" alt="image" src="https://user-images.githubusercontent.com/1736354/197310119-30332769-0553-4ffa-816c-97a5ec0b3c27.png">
And `See test results` set right.
https://github.com/Yikun/spark/pull/181/checks?check_run_id=9029035780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38341:
URL: https://github.com/apache/spark/pull/38341#issuecomment-1287574881
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
URL: https://github.com/apache/spark/pull/38341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38341:
URL: https://github.com/apache/spark/pull/38341#issuecomment-1287659874
@HyukjinKwon Thanks, it works: https://github.com/apache/spark/pull/38343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #38341: [SPARK-40871][INFRA] Upgrade actions/github-script to v6 and fix notify workflow
Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #38341:
URL: https://github.com/apache/spark/pull/38341#issuecomment-1287572112
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org