You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pranay Pandey (JIRA)" <ji...@apache.org> on 2009/04/21 14:51:47 UTC
[jira] Created: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using exisiting shipment and
invoice
Facilitate packing screen to use verified orders from Verify Pick screen by using exisiting shipment and invoice
----------------------------------------------------------------------------------------------------------------
Key: OFBIZ-2329
URL: https://issues.apache.org/jira/browse/OFBIZ-2329
Project: OFBiz
Issue Type: Sub-task
Reporter: Pranay Pandey
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701410#action_12701410 ]
Vikas Mayur commented on OFBIZ-2329:
------------------------------------
Thanks Akash,
Your patch is in trunk rev. 767394. I will port these changes to release09.04 branch if no one has any real objections and will close this issue as well.
Vikas
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701378#action_12701378 ]
Pranay Pandey commented on OFBIZ-2329:
--------------------------------------
Thanks Akash for providing patch.
I reviewed, tested this patch. Functionality is proper. Only those orders are being worked on Packing screen which have been verified from Verify Pick screen.
Few things in the patch I found which can be improved are:
1. Following ui label should is not neede.
{code}
<property key="OrderNotFound">
<value xml:lang="en">Order #${orderId} cannot be found</value>
</property>
You can use existing one
<property key="OrderErrorOrderIdNotFound">
<value xml:lang="en">ERROR: Order with ID [${orderId}] not found</value>
</property>
{code}
2.
{code}
<property key="NoShipGroupSequenceIdCannotProcess">
<value xml:lang="en">No ship group sequence ID. Cannot process</value>
</property>
To
<property key="NoShipGroupSequenceIdFoundCannotProcess">
<value xml:lang="en">No ship group sequence Id found can not process</value>
</property>
{code}
Also most of the ui labels are good candidate to moved on to OrderErrorUiLabels.xml.
3. In groovy you don't need to do this:
{code}UtilMisc.toMap("orderId", orderId){code}
4. I think you forgot to make a change in PackOrder.groovy here:
{code}request.setAttribute("errorMessageList", ['No ship group sequence ID. Cannot process.']);{code}
5. There are places in groovy and ftl where after adding new condition you have not reformatted the whole code inside that block and I think its a good idea because only those changes are visible which should be. Once a patch with these improvements is committed you can provide a patch which will only contain the reformatted code.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701472#action_12701472 ]
Vikas Mayur commented on OFBIZ-2329:
------------------------------------
Thanks again, Akash!
Your patch (OFBIZ-2329_Formatted) is in trunk rev. 767449
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329_Formatted.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur closed OFBIZ-2329.
------------------------------
Resolution: Fixed
Thanks Akash,
Your patch for formatting changes is in trunk rev. 767449 and both changes are in release09.04 at rev. 767394 and 767449.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329_Formatted.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2329:
----------------------------------
Assignee: Vikas Mayur
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-2329:
---------------------------------
Component/s: product
Fix Version/s: SVN trunk
Release Branch 9.04
Priority: Minor (was: Major)
Description:
Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
Packing of those orders should be allowed which are Verified from Verify Pick Screen.
Affects Version/s: SVN trunk
Release Branch 9.04
Summary: Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice (was: Facilitate packing screen to use verified orders from Verify Pick screen by using exisiting shipment and invoice)
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur updated OFBIZ-2329:
-------------------------------
Affects Version/s: (was: Release Branch 9.04)
Fix Version/s: (was: Release Branch 9.04)
Reverted changes from the release09.04 branch in r767590 after David's suggestion on dev list.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329_Formatted.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2329:
------------------------------
Attachment: OFBIZ-2329.patch
Thanks Pranay for reviewing the patch. I have done all the needful changes.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701387#action_12701387 ]
Pranay Pandey commented on OFBIZ-2329:
--------------------------------------
Akash, This is for your future patches. You should provide clear steps to test the functionality implemented, so that anybody from the community can review, test your work and can provide you improvement suggestions.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2329:
------------------------------
Attachment: OFBIZ-2329_Formatted.patch
This is a formatted patch.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329_Formatted.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2329:
------------------------------
Attachment: OFBIZ-2329.patch
Minor change in services_shipment.xml file.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2329:
------------------------------
Attachment: OFBIZ-2329.patch
Now same ShipmentId and InvoiceId is updated during "Packing" process, which is already been created in "Verify Pick" process.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2329) Facilitate packing screen to use
verified orders from Verify Pick screen by using existing shipment and
invoice
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701421#action_12701421 ]
Pranay Pandey commented on OFBIZ-2329:
--------------------------------------
Thanks Vikas for taking care of this.
Thanks Akash, now the next thing you can do is to reformat the code and submit a patch on this issue only as I mentioned in my last comment.
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice
> ---------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2329
> URL: https://issues.apache.org/jira/browse/OFBIZ-2329
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-2329.patch, OFBIZ-2329.patch, OFBIZ-2329.patch
>
>
> Facilitate packing screen to use verified orders from Verify Pick screen by using existing shipment and invoice.
> Packing of those orders should be allowed which are Verified from Verify Pick Screen.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.