[GitHub] [samza] shanthoosh commented on a diff in pull request #1615: SAMZA-2749: Startpoint bug fix

[GitBox <gi...@apache.org>]

shanthoosh commented on code in PR #1615:
URL: https://github.com/apache/samza/pull/1615#discussion_r909087063


##########
samza-core/src/main/java/org/apache/samza/startpoint/StartpointManager.java:
##########
@@ -317,15 +317,55 @@ public Map<TaskName, Map<SystemStreamPartition, Startpoint>> fanOut(Map<TaskName
    * @return fanned out Startpoints
    */
   public Map<SystemStreamPartition, Startpoint> getFanOutForTask(TaskName taskName) throws IOException {
+    return getStartpointFanOutPerTask(taskName)

Review Comment:
   @alnzng  Do we think it will be useful to emit a metric here when we are performing the CRUD operations on these fanout tasks(Like deleting a startpoint at a task level). 
   
   This will be useful because typically we rely upon logs of container runs to determine if the startpoint resolution/deletion had worked as expected. These logs will get purged after TTL expiration.
   
    If we agree to publish metrics, then it will help better monitor for samza jobs in production



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org