[jira] Updated: (DBCP-264) clear batch when closing statement

["Phil Steitz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phil Steitz updated DBCP-264:
-----------------------------

    Attachment: clearBatchPatch.txt

The logical place to insert a clearBatch is in PoolablePreparedStatement's passivate method.  The attached patch does that, but swallows any SQLException that occurs.  Since driver support for this is optional, I don't think we would want to propagate the associated SQLExceptions here; but I don't either like the swallowing and the fact that the try/throw/catch will be executed on every passivate for drivers that do not support batch processing.   Anyone have a better idea?

> clear batch when closing statement
> ----------------------------------
>
>                 Key: DBCP-264
>                 URL: https://issues.apache.org/jira/browse/DBCP-264
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.2.2
>            Reporter: Hauke Rabe
>             Fix For: 1.3
>
>         Attachments: clearBatchPatch.txt
>
>
> If a statement contains batch statements, these statements should be cleared on close. 
> Szenario:
> A pooled statement contains already some batch statements before an error occured. This error will be handled and finally the statement will be closed. Cause, it is a pooled statement the batch statements will be remaining in the pooled statement. On the next request the pooled statement will execute the batch statements from the first request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.