You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2020/04/21 20:51:32 UTC
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15777
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
IMPALA-9681: Fix LdapImpalaShellTest
LdapImpalaShellTest was broken by IMPALA-3343 which changed the
wording of the startup message printed by impala-shell. This patch
fixes the test.
Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M shell/impala_shell.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15777/1
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5686/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:35:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1:
Sorry about that. I wonder why the pre-commit tests didn't catch this?
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 00:01:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1:
I'm currently investigating why this test apparently isn't getting run by the pre-commit, but I think we can go ahead and submit this fix before fixing that
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 20:53:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1:
see: https://gerrit.cloudera.org/#/c/15778/
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:07:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 01:54:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5851/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:32:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:50:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9681: Fix LdapImpalaShellTest
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15777 )
Change subject: IMPALA-9681: Fix LdapImpalaShellTest
......................................................................
IMPALA-9681: Fix LdapImpalaShellTest
LdapImpalaShellTest was broken by IMPALA-3343 which changed the
wording of the startup message printed by impala-shell. This patch
fixes the test.
Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Reviewed-on: http://gerrit.cloudera.org:8080/15777
Reviewed-by: Andrew Sherman <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java
M shell/impala_shell.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Andrew Sherman: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15777
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e7070fa6da4085ea858f64141529a7a23a86534
Gerrit-Change-Number: 15777
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>