You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/13 03:25:05 UTC

[GitHub] [skywalking] zifeihan commented on a change in pull request #6715: Add `trace_segment_ref_limit_per_span` configuration mechanism to avoid OOM

zifeihan commented on a change in pull request #6715:
URL: https://github.com/apache/skywalking/pull/6715#discussion_r612100281



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/trace/TraceSegment.java
##########
@@ -121,16 +116,19 @@ public String getTraceSegmentId() {
         return traceSegmentId;
     }
 
-    public boolean hasRef() {
-        return !(refs == null || refs.size() == 0);
-    }
-
+    /**
+     * For testing use only.
+     */
     public List<TraceSegmentRef> getRefs() {

Review comment:
       done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org