You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/28 17:46:54 UTC

[GitHub] [beam] TobKed commented on a change in pull request #12716: [BEAM-10831] Fix broken Beam Dependency Check Report

TobKed commented on a change in pull request #12716:
URL: https://github.com/apache/beam/pull/12716#discussion_r479450128



##########
File path: .test-infra/jenkins/CommonJobProperties.groovy
##########
@@ -34,7 +34,10 @@ class CommonJobProperties {
       String defaultBranch = 'master',
       int defaultTimeout = 100,
       boolean allowRemotePoll = true,
-      String jenkinsExecutorLabel =  'beam') {
+      String jenkinsExecutorLabel = 'beam',
+      boolean cleanWorkspace = true) {
+
+    context.disabled()

Review comment:
       🙀  good point @tvalentyn . It is unwanted leftover from testing it on another Jenkins with some additional changes in CommonJobProperties. I deleted in recent fixup.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org