You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/12/03 19:19:49 UTC
Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1630
https://issues.apache.org/jira/browse/OOZIE-1630
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1630
Diffs
-----
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1547202
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
Diff: https://reviews.apache.org/r/15966/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/#review29677
-----------------------------------------------------------
trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki
<https://reviews.apache.org/r/15966/#comment57116>
Remove this line. If you default to fs uri handler it will use the fs.default.name in the job configuration which could be anything - hdfs, s3, webhdfs, etc.
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
<https://reviews.apache.org/r/15966/#comment57115>
Please do not blindly default to hdfs. If scheme is null revert to a default uri handler (FSURIHandler)
- Rohini Palaniswamy
On Dec. 3, 2013, 6:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15966/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 6:19 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1630
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
> trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1547202
> trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
>
> Diff: https://reviews.apache.org/r/15966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/#review29696
-----------------------------------------------------------
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
<https://reviews.apache.org/r/15966/#comment57145>
This is not required.
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java
<https://reviews.apache.org/r/15966/#comment57146>
you can just return a new FSLauncherURIHandler() here as you already know the class instead of moving instantiation by reflection from else block to the end.
- Rohini Palaniswamy
On Dec. 4, 2013, 1:10 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15966/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 1:10 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1630
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
> trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
>
> Diff: https://reviews.apache.org/r/15966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/#review29750
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Dec. 4, 2013, 6:08 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15966/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 6:08 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1630
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Repository: oozie
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1630
>
>
> Diffs
> -----
>
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
> trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
>
> Diff: https://reviews.apache.org/r/15966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 6:08 p.m.)
Review request for oozie.
Changes
-------
fixed
Bugs: OOZIE-1630
https://issues.apache.org/jira/browse/OOZIE-1630
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1630
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
Diff: https://reviews.apache.org/r/15966/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 1:10 a.m.)
Review request for oozie.
Bugs: OOZIE-1630
https://issues.apache.org/jira/browse/OOZIE-1630
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1630
Diffs
-----
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
Diff: https://reviews.apache.org/r/15966/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 1:10 a.m.)
Review request for oozie.
Changes
-------
uploaded wrong file previously. this is right one.
Bugs: OOZIE-1630
https://issues.apache.org/jira/browse/OOZIE-1630
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1630
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
Diff: https://reviews.apache.org/r/15966/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 15966: [OOZIE-1630] operations fail when path
doesn't have scheme
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15966/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 11 p.m.)
Review request for oozie.
Changes
-------
fixed review comments.
Bugs: OOZIE-1630
https://issues.apache.org/jira/browse/OOZIE-1630
Repository: oozie
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1630
Diffs (updated)
-----
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFSPrepareActions.java 1547202
trunk/docs/src/site/twiki/WorkflowFunctionalSpec.twiki 1547202
trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherURIHandlerFactory.java 1547202
Diff: https://reviews.apache.org/r/15966/diff/
Testing
-------
Thanks,
Ryota Egashira