You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 01:17:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #13557: Optimises prod image preparation in CI
potiuk opened a new pull request #13557:
URL: https://github.com/apache/airflow/pull/13557
The prod images require CI images to build provider packages.
The optmisation implemented makes the CI images built only once
and the prod images will just pull the images rather than build
them again.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13557: Optimises prod image preparation in CI
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13557:
URL: https://github.com/apache/airflow/pull/13557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13557: Optimises prod image preparation in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13557:
URL: https://github.com/apache/airflow/pull/13557#issuecomment-756587870
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13557: Optimises prod image preparation in CI
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13557:
URL: https://github.com/apache/airflow/pull/13557#issuecomment-756501523
[The Workflow run](https://github.com/apache/airflow/actions/runs/470526453) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13557: Optimises prod image preparation in CI
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13557:
URL: https://github.com/apache/airflow/pull/13557#issuecomment-756486362
This PR should optimese a bit prod image preparation - instead of building CI images twice (we need them for prod images) we just wait with the PROD images until CI images are built and we pull them. This should have no impact on the elapsed time of the build because the PROD images are used for much faster K8S builds, so this is not problem if they are prepared a little later.
Tested : https://github.com/potiuk/airflow/actions/runs/470430011 (build) and https://github.com/potiuk/airflow/actions/runs/470429997 (CI) (needs to be built in the main branch).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org