You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/16 05:15:50 UTC

[GitHub] [beam] amaliujia commented on a change in pull request #11957: [BEAM-10033] zetaSqlValueToJavaObject uses value.getType()

amaliujia commented on a change in pull request #11957:
URL: https://github.com/apache/beam/pull/11957#discussion_r440590858



##########
File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlUtils.java
##########
@@ -196,7 +196,55 @@ private static Value beamLogicalObjectToZetaSqlValue(Object object, String ident
     }
   }
 
-  // Value conversion: ZetaSQL => Beam
+  // Type conversion: ZetaSQL => Beam
+  public static FieldType zetaSqlTypeToBeamFieldType(Type type) {

Review comment:
       Out of curiosity: so the ZetaSQL type does not carry nullability? (otherwise seems the nullability of the type has lost in this conversion).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org