You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Gwyn Evans (JIRA)" <ji...@apache.org> on 2007/11/02 10:07:50 UTC
[jira] Created: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Inner form validators not skipped when inner form disabled
----------------------------------------------------------
Key: WICKET-1124
URL: https://issues.apache.org/jira/browse/WICKET-1124
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.0-beta4
Reporter: Gwyn Evans
Priority: Minor
The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
/Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Gwyn Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539545 ]
Gwyn Evans commented on WICKET-1124:
------------------------------------
There is WICKET-709, which added the ability to remove the Validator, but (without yet looking at the source) I suspect the best way might be to have the validator check it's component is visible before validating.
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Priority: Minor
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-1124:
-----------------------------------
Assignee: Matej Knopp
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552750 ]
Gerolf Seitz commented on WICKET-1124:
--------------------------------------
i have created a wiki page[0] that should act as a specification to document how nested forms are *intended* to work.
currently, there are 11 scenarios on the page, and i have modified form handling, so that all 11 scenarios in form of unit tests are passed.
please take some time to review the scenarios and add new scenarios that should be covered too and/or comment on existing scenarios, should you not agree with the specified behavior.
[0] http://cwiki.apache.org/WICKET/nested-forms.html
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc3
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1124:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc3)
1.3.1
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz updated WICKET-1124:
---------------------------------
Attachment: (was: WICKET-1124.patch)
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1124) Inner form validators not skipped when
inner form disabled
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz closed WICKET-1124.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.3)
1.3.1
Assignee: Gerolf Seitz (was: Matej Knopp)
i think we can close this one.
the enhanced nested forms support has been available since the 1.3.1 release.
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Gerolf Seitz
> Priority: Minor
> Fix For: 1.3.1
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz updated WICKET-1124:
---------------------------------
Attachment: WICKET-1124.patch
the attached patch handles nested forms according to the "specification" at http://cwiki.apache.org/WICKET/nested-forms.html
since this involved quite some changes of the form processing codebase, i will also start a vote on dev@, whether this patch should be applied before the (hopefully soon) coming 1.3.0-rc3/final
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Gerolf Seitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerolf Seitz updated WICKET-1124:
---------------------------------
Attachment: WICKET-1124.patch
patch no longer includes FormTester (just committed the changes anyway), as it's not really part of the "problem"
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc3
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1124:
---------------------------------------
Fix Version/s: (was: 1.3.1)
1.3.2
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.2
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1124:
---------------------------------------
Fix Version/s: (was: 1.3.2)
1.3.3
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.3
>
> Attachments: WICKET-1124.patch
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1124:
------------------------------------
Fix Version/s: 1.3.0-rc2
are we going to fix this for 1.3? It would be nice to have this in an unit test !
Does anybody has one that we can include?
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc2
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1124) Inner form validators not skipped
when inner form disabled
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1124:
---------------------------------------
Fix Version/s: (was: 1.3.0-rc2)
1.3.0-rc3
> Inner form validators not skipped when inner form disabled
> ----------------------------------------------------------
>
> Key: WICKET-1124
> URL: https://issues.apache.org/jira/browse/WICKET-1124
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.0-beta4
> Reporter: Gwyn Evans
> Assignee: Matej Knopp
> Priority: Minor
> Fix For: 1.3.0-rc3
>
>
> The specific issue I've just run across is where I have a outer form and, depending upon a checkbox, might have an inner form being enabled or not. (It's an inner form, rather than just a part of the main form as it's off as a component with it's own panel.)
> Anyway, the inner form has password/confirmPassword fields and an EqualInputValidator, but if the form is displayed but then disabled again (via Ajax, if significant,) when the form's finally submitted I get a warning, saying "IFormValidator in form '...' depends on a component that has been removed from the page or is no longer visible. Offending component id `password`."
> As Igor commented, "looks like we need to update form processing code to skip inner disabled forms".
> /Gwyn
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.