You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/09/01 13:07:05 UTC

[GitHub] [cordova-plugin-screen-orientation] SunboX opened a new pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

SunboX opened a new pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-screen-orientation] SunboX commented on pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

Posted by GitBox <gi...@apache.org>.
SunboX commented on pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74#issuecomment-684839161


   this fixes issue #73 and also a minor bug in the code itself


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-screen-orientation] erisu commented on pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74#issuecomment-723681427


   Could you rebase this PR?
   
   After rebasing, I think the iOS failing tests will pass again. As for the browser tests, they still failing for some other reasons.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-screen-orientation] SunboX commented on pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

Posted by GitBox <gi...@apache.org>.
SunboX commented on pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74#issuecomment-684926567


   there seems to be an issue in cordova-parametic:
   ```
   ---------------------------------------------------------
   4. Run (Jasmine) tests...
   ... locally
   ---------------------------------------------------------
   cordova-paramedic: running tests locally
   cordova-paramedic: Choosing Target for iOS
   running:
       cordova run --list --emulator --no-telemetry --no-update-notifier
   Error: Cannot read property 'trim' of undefined
   TypeError: Cannot read property 'trim' of undefined
       at Object.getSimulatorModelId (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/utils/utilities.js:92:9)
       at ParamedicTargetChooser.chooseTargetForIOS (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/ParamedicTargetChooser.js:136:44)
       at ParamedicTargetChooser.chooseTarget (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/ParamedicTargetChooser.js:43:30)
       at ParamedicRunner.getCommandForStartingTests (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:427:80)
       at /Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:239:30
   From previous event:
       at ParamedicRunner.runLocalTests (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:280:14)
       at ParamedicRunner.runTests (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:376:25)
       at /Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:93:29
   From previous event:
       at ParamedicRunner.run (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:79:14)
       at Object.exports.run (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:502:19)
       at Object.<anonymous> (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/main.js:184:15)
       at Module._compile (internal/modules/cjs/loader.js:1137:30)
       at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
       at Module.load (internal/modules/cjs/loader.js:985:32)
       at Function.Module._load (internal/modules/cjs/loader.js:878:14)
       at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
   ---------------------------------------------------------
   6. Collect data and clean up
   ---------------------------------------------------------
   Completed tests at 2:57:36 PM
   Collecting logs for the devices.
   It looks like there is no target to get logs from.
   Uninstalling the app.
   cordova-paramedic: Killing the emulator process.
   Running the following command:
       killall -9 "Simulator" "iOS Simulator"
   $ killall -9 "Simulator" "iOS Simulator"
   No matching processes belonging to you were found
   WARNING: kill command returned 1
   local-server: killing local file transfer server if it's up...
   cordova-paramedic: Deleting the application: /var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/tmp-3781kPQL4fLQ7gi7
   /Users/travis/build/apache/cordova-plugin-screen-orientation
   Error: TypeError: Cannot read property 'trim' of undefined
       at /Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:99:23
       at processTicksAndRejections (internal/process/task_queues.js:79:11)
   From previous event:
       at ParamedicRunner.run (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:96:19)
       at Object.exports.run (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/lib/paramedic.js:502:19)
       at Object.<anonymous> (/Users/travis/.nvm/versions/node/v12.18.3/lib/node_modules/cordova-paramedic/main.js:184:15)
       at Module._compile (internal/modules/cjs/loader.js:1137:30)
       at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
       at Module.load (internal/modules/cjs/loader.js:985:32)
       at Function.Module._load (internal/modules/cjs/loader.js:878:14)
   The command "if [[ "$ADDITIONAL_TESTS_DIR" != "" ]]; then
     cd $ADDITIONAL_TESTS_DIR && npm install && npm test;
   else 
     $PARAMEDIC_COMMAND --config ./pr/$PLATFORM --plugin $PARAMEDIC_PLUGIN_TO_TEST --buildName $PARAMEDIC_BUILDNAME; 
   fi" exited with 1.
   cache.2
   store build cache
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-screen-orientation] erisu edited a comment on pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

Posted by GitBox <gi...@apache.org>.
erisu edited a comment on pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74#issuecomment-723681427


   Could you rebase this PR? @SunboX
   
   After rebasing, I think the iOS failing tests will pass again. As for the browser tests, they still failing for some other reasons.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-plugin-screen-orientation] erisu commented on pull request #74: fix(R7-9625): fix plugin for use with webpack - fixes #73

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #74:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/74#issuecomment-684934337


   @SunboX Yes, we are aware of the paramedic issue and have been actively trying to resolve the test framework.
   
   We will re-run the tests after we have fixed the testing framework.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org