You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/12 03:57:19 UTC
[GitHub] [incubator-shardingsphere] geomonlin opened a new pull request
#4718: Update faq
geomonlin opened a new pull request #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718
Fixes #4604 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4718:
Update faq
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#4718: Update faq
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718#issuecomment-598004204
@geomonlin Hi
Could you append `(Version >= 3.0.0.M3)` to the second item? For instance,
> Configure `max.connections.size.per.query`(Default value is 1) higher referring to connection pool you adopt (Version >= 3.0.0.M3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #4718:
Update faq
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718#issuecomment-598004204
@geomonlin Hi
Could you add `(Version >= 3.0.0.M3)` to the second item? For instance,
> Configure `max.connections.size.per.query`(Default value is 1) higher referring to connection pool you adopt (Version >= 3.0.0.M3).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4718:
Update faq
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718#issuecomment-598001404
## Pull Request Test Coverage Report for [Build 10187](https://coveralls.io/builds/29293495)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.005%**) to **59.087%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29293495/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29293495) |
| :-- | --: |
| Change from base [Build 1050](https://coveralls.io/builds/29292785): | -0.005% |
| Covered Lines: | 12185 |
| Relevant Lines: | 20622 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4718:
Update faq
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4718: Update faq
URL: https://github.com/apache/incubator-shardingsphere/pull/4718#issuecomment-597998079
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4718?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@cf8bba7`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4718?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4718 +/- ##
=========================================
Coverage ? 55.53%
Complexity ? 426
=========================================
Files ? 1137
Lines ? 20622
Branches ? 3819
=========================================
Hits ? 11452
Misses ? 8449
Partials ? 721
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4718?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4718?src=pr&el=footer). Last update [cf8bba7...700e054](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services