You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 08:17:32 UTC
[jira] [Created] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
TaxonomyReader/Writer and their Lucene* implementation
------------------------------------------------------
Key: LUCENE-3552
URL: https://issues.apache.org/jira/browse/LUCENE-3552
Project: Lucene - Java
Issue Type: Improvement
Components: modules/facet
Reporter: Shai Erera
Assignee: Shai Erera
Priority: Trivial
Fix For: 3.5, 4.0
The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
# Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
# Keep the interfaces, but rename the Lucene* impls to Directory*.
Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Shai Erera (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera resolved LUCENE-3552.
--------------------------------
Resolution: Fixed
Thanks Doron, good catch !
I also renamed o.a.l.facet.taxonomy.lucene to *.directory.
Committed revision 1196963 (trunk).
Committed revision 1196965 (3x).
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3552.patch
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142031#comment-13142031 ]
Shai Erera commented on LUCENE-3552:
------------------------------------
What do you mean? If we'll combine the search and taxonomy index, I don't believe we'll call it TaxonomyWriter. The purpose of the interface is for allowing a different implementation of the taxonomy, i.e. something that is not based on a Lucene Directory (e.g. a DB or something).
Perhaps I misunderstand you?
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Shai Erera (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-3552:
-------------------------------
Attachment: LUCENE-3552.patch
Patch renames LTW/R to DirectoryTW/TR. Also, I renamed LTW's openLuceneIndex/closeLuceneIndex to open/closeIndexWriter.
I've also made TW extend TwoPhaseCommit.
I think that it's ready to commit. I'll port the changes to trunk afterwards. I'll wait until tomorrow before I commit (the changes are trivial).
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3552.patch
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Dafna Sheinwald (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142082#comment-13142082 ]
Dafna Sheinwald commented on LUCENE-3552:
-----------------------------------------
Hi Shai,
Yes, the old (already forgotten) DB implementation of taxonomy index, and the subsequent Lucene implementation gave rise to the definition of TaxonomyReader/Writer interface. Currently, indeed, and we are left with Lucene (Directory) implementation only. But I thought that as the interface is already there, and we have some thoughts of yet another implementation of taxonomy index (and hence TaxonomyReader/Writer), as part of the Lucene search index, which may help to ease the burden of synch between these two indices, why not let the interface live a bit longer before we remove it. Regards, Dafna.
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Dafna Sheinwald (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142024#comment-13142024 ]
Dafna Sheinwald commented on LUCENE-3552:
-----------------------------------------
Hi Shai,
I would vote for (2). We may want to still maintain the option to implement both in one Lucene index, in order to avoid the burden of synch-ing them.
Regards, Dafna.
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Doron Cohen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142192#comment-13142192 ]
Doron Cohen commented on LUCENE-3552:
-------------------------------------
Shai Patch looks good!
Applies cleanly (after svn mv'ing the two renamed classes) and all facet tests run.
Only userguide.html still mentions the old classes:
{code}
TaxonomyWriter taxo = new LuceneTaxonomyWriter(taxoDir, OpenMode.CREATE);
..
TaxonomyReader taxo = new LuceneTaxonomyReader(taxoDir);
{code}
Other than that good to go.
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
> Attachments: LUCENE-3552.patch
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3552) TaxonomyReader/Writer and their
Lucene* implementation
Posted by "Shai Erera (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142108#comment-13142108 ]
Shai Erera commented on LUCENE-3552:
------------------------------------
Ok, let's keep the interface. It's harmful and I can certainly think of alternate taxonomy implementations. Perhaps one day someone would want to implement the taxonomy over a serialized FST or some other data structure ...
So in this case, I'll:
* Keep the interfaces
* Make TaxomomyWriter extend TwoPhaseCommit
* Rename Lucene TaxoWriter/Reader to DirectoryTaxoWriterReader.
Any suggestions about an alternative names to the implementations?
> TaxonomyReader/Writer and their Lucene* implementation
> ------------------------------------------------------
>
> Key: LUCENE-3552
> URL: https://issues.apache.org/jira/browse/LUCENE-3552
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Trivial
> Fix For: 3.5, 4.0
>
>
> The facet module contains two interfaces TaxonomyWriter and TaxonomyReader, with two implementations Lucene*. We've never actually implemented two TaxonomyWriters/Readers, so I'm not sure if these interfaces are useful anymore. Therefore I'd like to propose that we do either of the following:
> # Remove the interfaces and remove the Lucene part from the implementation classes (to end up with TW/TR impls). Or,
> # Keep the interfaces, but rename the Lucene* impls to Directory*.
> Whatever we do, I'd like to make the impls/interfaces impl also TwoPhaseCommit.
> Any preferences?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org