Re: [PR] KAFKA-19878 : Connect | Fixed order of arguments in assertEquals in connect package [kafka]

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #21112:
URL: https://github.com/apache/kafka/pull/21112#discussion_r4350764781


##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java:
##########
@@ -156,8 +156,8 @@ public void testSkipRetryAndDLQWithHeaders() throws Exception {
             String k = new String(rec.key());
             String v = new String(rec.value());
             log.debug("Consumed record (key='{}', value='{}') from topic {}", k, v, rec.topic());
-            assertEquals(k, "key-" + i, "Unexpected key");
-            assertEquals(v, "value-" + i, "Unexpected value");
+            assertEquals("key-" + i, k, "Unexpected key");
+            assertEquals("value-" + i, v,"Unexpected value");

Review Comment:
   This is failing checkstyle, we need a space after the comma. Same issue below



##########
connect/api/src/test/java/org/apache/kafka/connect/data/DateTest.java:
##########
@@ -70,8 +70,8 @@ public void testFromLogicalInvalidHasTimeComponents() {
 
     @Test
     public void testToLogical() {
-        assertEquals(EPOCH.getTime(), Date.toLogical(Date.SCHEMA, 0));
-        assertEquals(EPOCH_PLUS_TEN_THOUSAND_DAYS.getTime(), Date.toLogical(Date.SCHEMA, 10000));
+        assertEquals(Date.toLogical(Date.SCHEMA, 0), EPOCH.getTime());

Review Comment:
   I think the order of the assertions in connect/api is correct. can you revert the changes in these files?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org