[GitHub] [helix] zhangmeng916 commented on a change in pull request #653: add Helix properties factory and class

[GitBox <gi...@apache.org>]

zhangmeng916 commented on a change in pull request #653: add Helix properties factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r362586401
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
 ##########
 @@ -202,6 +205,11 @@ public ZKHelixManager(String clusterName, String instanceName, InstanceType inst
 
   public ZKHelixManager(String clusterName, String instanceName, InstanceType instanceType,
       String zkAddress, HelixManagerStateListener stateListener) {
+    this(clusterName, instanceName, instanceType, zkAddress,stateListener, null);
+  }
+
+  public ZKHelixManager(String clusterName, String instanceName, InstanceType instanceType,
+      String zkAddress, HelixManagerStateListener stateListener, HelixParticipantProperty helixParticipantProperty) {
 
 Review comment:
   I'm thinking whether it's better to change to HelixManagerProperty. Let's discuss further.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org