You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/06 04:13:42 UTC
[GitHub] [spark] viirya commented on a change in pull request #35639: [SPARK-38423][K8S] Support priority scheduling with Volcano implementations
viirya commented on a change in pull request #35639:
URL: https://github.com/apache/spark/pull/35639#discussion_r820177558
##########
File path: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/VolcanoTestsSuite.scala
##########
@@ -201,4 +319,21 @@ private[spark] object VolcanoTestsSuite extends SparkFunSuite {
getClass.getResource("/volcano/disable-queue0-enable-queue1.yml").getFile
).getAbsolutePath
val GROUP_PREFIX = "volcano-test" + UUID.randomUUID().toString.replaceAll("-", "")
+ val VOLCANO_PRIORITY_YAML
+ = new File(getClass.getResource("/volcano/priorityClasses.yml").getFile).getAbsolutePath
+ val HIGH_PRIORITY_DRIVER_TEMPLATE = new File(
+ getClass.getResource("/volcano/high-priority-driver-template.yml").getFile
+ ).getAbsolutePath
+ val MEDIUM_PRIORITY_DRIVER_TEMPLATE = new File(
+ getClass.getResource("/volcano/medium-priority-driver-template.yml").getFile
+ ).getAbsolutePath
+ val LOW_PRIORITY_DRIVER_TEMPLATE = new File(
+ getClass.getResource("/volcano/low-priority-driver-template.yml").getFile
+ ).getAbsolutePath
Review comment:
Hm, where did you use `LOW_PRIORITY_DRIVER_TEMPLATE`, `MEDIUM_PRIORITY_DRIVER_TEMPLATE` and `HIGH_PRIORITY_DRIVER_TEMPLATE`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org