[GitHub] [geode] DonalEvans commented on a diff in pull request #7633: GEODE-10266: update SeveralGatewayReceiversWithSamePortAndHostnameFor…

[GitBox <gi...@apache.org>]

DonalEvans commented on code in PR #7633:
URL: https://github.com/apache/geode/pull/7633#discussion_r861967352


##########
geode-assembly/src/acceptanceTest/java/org/apache/geode/cache/wan/SeveralGatewayReceiversWithSamePortAndHostnameForSendersTest.java:
##########
@@ -258,7 +258,8 @@ public void testPingsToReceiversWithSamePortAndHostnameForSendersUseOnlyOneMoreC
 
     await().untilAsserted(() -> assertThat(getSenderPoolDisconnects(vm1, senderId)).isEqualTo(0));
 
-    await().untilAsserted(() -> assertThat(getSenderPoolConnects(vm1, senderId)).isEqualTo(4));
+    await().untilAsserted(
+        () -> assertThat(getSenderPoolConnects(vm1, senderId)).isLessThanOrEqualTo(4));

Review Comment:
   Why is the number of pool connects not deterministic in this test? Is the fact that it can vary a bug, or expected behaviour?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org