[jira] [Resolved] (MRELEASE-982) Wrong log message when setting suppressCommitBeforeTagOrBranch to true

["Elliotte Rusty Harold (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MRELEASE-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Elliotte Rusty Harold resolved MRELEASE-982.
--------------------------------------------
    Resolution: Fixed

> Wrong log message when setting suppressCommitBeforeTagOrBranch to true
> ----------------------------------------------------------------------
>
>                 Key: MRELEASE-982
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-982
>             Project: Maven Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.3, 2.4, 2.5
>            Reporter: Stefan Prietl
>            Assignee: Elliotte Rusty Harold
>            Priority: Trivial
>              Labels: log
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> When setting {{suppressCommitBeforeTagOrBranch}} to {{true}} it actually logs the following:
> {noformat}
> [INFO] Modified POMs are not committed because suppressCommitBeforeTagOrBranch is set to false.
> {noformat}
> The "error" in this case seems to be a misinterpreted {{else}} clause in the code of [ScmCommitPreparationPhase.java (line 62)|http://svn.apache.org/viewvc/maven/release/trunk/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/ScmCommitPreparationPhase.java?view=markup#l62].
> This is a minor annoyance when trying to find the cause of a released pom not being updated in the VCS' tag and seeing this paradox message in the log file.
> Actually, the [patch in issue MVN-745|https://issues.apache.org/jira/secure/attachment/12718278/maven-release-manager.patch] provided by my doppelganger [~seder] would fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)