You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by anita kulshreshtha <a_...@yahoo.com> on 2007/01/03 05:11:54 UTC

M2 : Assemblies [was Re: svn commit: r489358 - in /geronimo/server/trunk: configs/pom.xml pom.xml]

   Numerous  problems have been reported with building 'assemblies' and

with the server resulting from these assemblies. Here are some of them:
Oct 19 -
http://www.nabble.com/Assembly-is-caching-old-junk-p6907158.html 
Oct 31 -
http://www.nabble.com/More-car-maven-plugin-changes...-p7107517.html
Nov17 - 
http://www.nabble.com/build-problems---GBeanInfo-serialVersionUID-tf2656539.html#a7410086
Nov 28 - 
http://www.nabble.com/-jira--Created%3A-%28GERONIMO-2603%29-Building-1.2-if-there-are-2.0-artifacts-in-the-repo-results-in-mostly-2.0-artifacts-in-the-server.-tf2721824.html#a7590723
Dec 14 - http://issues.apache.org/jira/browse/GERONIMO-2663
Dec 15 - 
http://www.nabble.com/Trunk-runtime-error-GBeanInstanceState--deserializing-GBeanState-tf2829126.html#a7948415
Dec 20 - http://www.nabble.com/boilerplate-j2ee-Assembly-p7994691.html

After each report an attempt was made to fix the car plugin! These
fixes tried to treat the symptoms and not the root cause of the
problem.
   
I believe the following change I have made is the only thing needed to 
fix all of the above problems. These were all caused because the 
version for the car plugin was left unspecified. It was left upto maven
to pick an *available* version for the car plugin and use it to install
the configs during assemblies! For details see:
https://issues.apache.org/jira/browse/GERONIMO-2675

Thanks
Anita

--- akulshreshtha@apache.org wrote:

> Author: akulshreshtha
> Date: Thu Dec 21 06:03:56 2006
> New Revision: 489358
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=489358
> Log:
> GERONIMO-2675 Move car-maven-plugin to top level pluginManagement
> section. This will allow assemblies to inherit
> the version used by the configs
> 
> Modified:
>     geronimo/server/trunk/configs/pom.xml
>     geronimo/server/trunk/pom.xml
> 
> Modified: geronimo/server/trunk/configs/pom.xml
> URL:
>
http://svn.apache.org/viewvc/geronimo/server/trunk/configs/pom.xml?view=diff&rev=489358&r1=489357&r2=489358
>
==============================================================================
> --- geronimo/server/trunk/configs/pom.xml (original)
> +++ geronimo/server/trunk/configs/pom.xml Thu Dec 21 06:03:56 2006
> @@ -85,17 +85,6 @@
>          </extensions>
>          -->
>  
> -        <pluginManagement>
> -            <plugins>
> -                <plugin>
> -                    <groupId>org.apache.geronimo.plugins</groupId>
> -                    <artifactId>car-maven-plugin</artifactId>
> -                    <version>${version}</version>
> -                    <extensions>true</extensions>
> -                </plugin>
> -            </plugins>
> -        </pluginManagement>
> -
>          <plugins>
>              <plugin>
>                  <groupId>org.apache.geronimo.plugins</groupId>
> 
> Modified: geronimo/server/trunk/pom.xml
> URL:
>
http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?view=diff&rev=489358&r1=489357&r2=489358
>
==============================================================================
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Thu Dec 21 06:03:56 2006
> @@ -1246,6 +1246,13 @@
>          <pluginManagement>
>              <plugins>
>                  <plugin>
> +                    <groupId>org.apache.geronimo.plugins</groupId>
> +                    <artifactId>car-maven-plugin</artifactId>
> +                    <version>${version}</version>
> +                    <extensions>true</extensions>
> +                </plugin>
> +
> +                <plugin>
>                      <groupId>org.codehaus.mojo</groupId>
>                      <artifactId>xmlbeans-maven-plugin</artifactId>
>                      <version>2.0.1-SNAPSHOT</version>
> 
> 
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

Re: M2 : Assemblies [was Re: svn commit: r489358 - in /geronimo/server/trunk: configs/pom.xml pom.xml]

Posted by Jason Dillon <ja...@planet57.com>.
On Jan 2, 2007, at 8:11 PM, anita kulshreshtha wrote:
> After each report an attempt was made to fix the car plugin! These
> fixes tried to treat the symptoms and not the root cause of the
> problem.

No, there were some real problems with the car plugin, probably a few  
more too.


> I believe the following change I have made is the only thing needed to
> fix all of the above problems. These were all caused because the
> version for the car plugin was left unspecified. It was left upto  
> maven
> to pick an *available* version for the car plugin and use it to  
> install
> the configs during assemblies! For details see:
> https://issues.apache.org/jira/browse/GERONIMO-2675

I really don't think so.  I don't deny that not specifying the  
version has left some uncertainly, but it certainly was not the cause  
of all of the problems you reference below.


>    Numerous  problems have been reported with building 'assemblies'  
> and
>
> with the server resulting from these assemblies. Here are some of  
> them:
> Oct 19 -
> http://www.nabble.com/Assembly-is-caching-old-junk-p6907158.html
> Oct 31 -
> http://www.nabble.com/More-car-maven-plugin-changes...-p7107517.html

Why do you think that caching of old junk was related in any way to  
the version of the car plugin being omitted?  Most of these problems  
were actually in configs/* modules which did have the version specified.

The rest... well, I'm not really sure.  Some of this might be caused  
by the version being ommited.  It would be interesting to know after  
the change you made if anymore of these evil serialVersionUID errors  
pop up.


> Nov17 -
> http://www.nabble.com/build-problems---GBeanInfo-serialVersionUID- 
> tf2656539.html#a7410086
> Nov 28 -
> http://www.nabble.com/-jira--Created%3A-%28GERONIMO-2603%29- 
> Building-1.2-if-there-are-2.0-artifacts-in-the-repo-results-in- 
> mostly-2.0-artifacts-in-the-server.-tf2721824.html#a7590723
> Dec 14 - http://issues.apache.org/jira/browse/GERONIMO-2663
> Dec 15 -
> http://www.nabble.com/Trunk-runtime-error-GBeanInstanceState-- 
> deserializing-GBeanState-tf2829126.html#a7948415
> Dec 20 - http://www.nabble.com/boilerplate-j2ee-Assembly-p7994691.html

Anyways, there were *real* problems with the car plugin.  The version  
should have also been specified and its good you found that... but I  
really don't think that all problems we have been seeing with cars  
simply goes way by setting the version.  If only life was that  
easy... I'm afraid its not.

--jason