You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/16 22:34:56 UTC
[GitHub] [incubator-mxnet] apeforest opened a new pull request #17348: Fix
Horovod build error due to missing exported symbols
apeforest opened a new pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348
## Description ##
Export MXAPIHandle symbol and fixes https://github.com/apache/incubator-mxnet/issues/17292
## Comments ##
@szha Please help to review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17348: Fix Horovod build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r368266596
##########
File path: make/config/libmxnet.sym
##########
@@ -12,4 +12,4 @@ Java_org_apache_mxnet*
*Storage*Get*
*on_enter_api*
*on_exit_api*
-*MXAPISetLastError*
+*MXAPIHandleException*
Review comment:
Updated. Please review again. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on a change in pull request
#17348: Fix Horovod build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r367790272
##########
File path: make/config/libmxnet.sym
##########
@@ -12,4 +12,4 @@ Java_org_apache_mxnet*
*Storage*Get*
*on_enter_api*
*on_exit_api*
-*MXAPISetLastError*
+*MXAPIHandleException*
Review comment:
Isn't this covered by the first line? If not, should we expand the pattern for the first line instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha commented on a change in pull request
#17348: Fix Horovod build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r368258561
##########
File path: make/config/libmxnet.sym
##########
@@ -12,4 +12,4 @@ Java_org_apache_mxnet*
*Storage*Get*
*on_enter_api*
*on_exit_api*
-*MXAPISetLastError*
+*MXAPIHandleException*
Review comment:
Let's fix the first line then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] szha merged pull request #17348: Fix Horovod
build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
szha merged pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17348: Fix Horovod build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r368088331
##########
File path: make/config/libmxnet.sym
##########
@@ -12,4 +12,4 @@ Java_org_apache_mxnet*
*Storage*Get*
*on_enter_api*
*on_exit_api*
-*MXAPISetLastError*
+*MXAPIHandleException*
Review comment:
I believe the first line misses the prefix before MX. Not sure if we want to whitelist all *MX* APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on a change in pull request
#17348: Fix Horovod build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
apeforest commented on a change in pull request #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#discussion_r368088331
##########
File path: make/config/libmxnet.sym
##########
@@ -12,4 +12,4 @@ Java_org_apache_mxnet*
*Storage*Get*
*on_enter_api*
*on_exit_api*
-*MXAPISetLastError*
+*MXAPIHandleException*
Review comment:
I believe the first line misses the prefix before MX. Not sure if we want to whitelist all ```*MX*``` APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] apeforest commented on issue #17348: Fix Horovod
build error due to missing exported symbols
Posted by GitBox <gi...@apache.org>.
apeforest commented on issue #17348: Fix Horovod build error due to missing exported symbols
URL: https://github.com/apache/incubator-mxnet/pull/17348#issuecomment-576816702
@szha Thanks for the review and update. Please let me know if this is good to ship.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services