You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/15 17:37:15 UTC
[GitHub] [cordova-fetch] raphinesse opened a new pull request #89: refactor: use async/await where applicable
raphinesse opened a new pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Preparation of a potential fix for https://github.com/apache/cordova-lib/issues/859
Also: https://github.com/apache/cordova/issues/175
### Description
<!-- Describe your changes in detail -->
Use async/await where applicable
### Testing
<!-- Please describe in detail how you tested your changes. -->
All automated tests still pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] raphinesse commented on pull request #89: refactor: use async/await where applicable
Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89#issuecomment-709899451
> One of these days I suppose I'll get used to this newfangled syntax, but I still think promises are more readable and make the async steps more explicit
Promises are definitely more explicit and allow for very pretty code sometimes. And I also agree with async/await taking some getting used to. But once you are used to it, I think it really excels at making control flow involving async functions easier and more readable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io edited a comment on pull request #89: refactor: use async/await where applicable
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89#issuecomment-709595967
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=h1) Report
> Merging [#89](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/8dc1fe1685d8fdb39a51017fbf300ba9b57366a5?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `89.74%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 92.30% 92.42% +0.11%
==========================================
Files 1 1
Lines 65 66 +1
==========================================
+ Hits 60 61 +1
Misses 5 5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/89/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `92.42% <89.74%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=footer). Last update [8dc1fe1...6511ecc](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] raphinesse edited a comment on pull request #89: refactor: use async/await where applicable
Posted by GitBox <gi...@apache.org>.
raphinesse edited a comment on pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89#issuecomment-709899451
> One of these days I suppose I'll get used to this newfangled syntax, but I still think promises are more readable and make the async steps more explicit
Promises are definitely more explicit and allow for very pretty code sometimes. And I also agree with async/await taking some getting used to. But once you are used to it, I think it really excels at making control flow involving async functions easier and more readable.
Anyway, thanks for the reviews :bow:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] raphinesse merged pull request #89: refactor: use async/await where applicable
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-fetch] codecov-io commented on pull request #89: refactor: use async/await where applicable
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #89:
URL: https://github.com/apache/cordova-fetch/pull/89#issuecomment-709595967
# [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=h1) Report
> Merging [#89](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-fetch/commit/8dc1fe1685d8fdb39a51017fbf300ba9b57366a5?el=desc) will **increase** coverage by `0.11%`.
> The diff coverage is `89.74%`.
[](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 92.30% 92.42% +0.11%
==========================================
Files 1 1
Lines 65 66 +1
==========================================
+ Hits 60 61 +1
Misses 5 5
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [index.js](https://codecov.io/gh/apache/cordova-fetch/pull/89/diff?src=pr&el=tree#diff-aW5kZXguanM=) | `92.42% <89.74%> (+0.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=footer). Last update [8dc1fe1...6511ecc](https://codecov.io/gh/apache/cordova-fetch/pull/89?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org