You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Weiwei Yang (JIRA)" <ji...@apache.org> on 2017/06/15 14:15:00 UTC
[jira] [Comment Edited] (YARN-6517) Fix warnings from Spotbugs in
hadoop-yarn-common
[ https://issues.apache.org/jira/browse/YARN-6517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050539#comment-16050539 ]
Weiwei Yang edited comment on YARN-6517 at 6/15/17 2:14 PM:
------------------------------------------------------------
Hi [~Naganarasimha]
Thanks for finding this, my bad, I overlooked the message
bq. +1 findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
I guess I was just looking at +1 but did not saw 1 unchanged. Sorry about that. I just tried you suggestion and that fix the problem, thank you very much. Should I reopen this one or file a new JIRA to get this fixed? I have attached the patch in this JIRA [^YARN-6517.003.patch].
Thank you.
was (Author: cheersyang):
Hi [~Naganarasimha]
Thanks for finding this, my bad, I overlooked the message
bq. +1 findbugs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
I guess I was just looking at +1 but did not saw 1 unchanged. Sorry about that. I just tried you suggestion and that fix the problem, thank you very much. Should I reopen this one or file a new JIRA to get this fixed? I have attached the patch in this JIRA.
Thank you.
> Fix warnings from Spotbugs in hadoop-yarn-common
> ------------------------------------------------
>
> Key: YARN-6517
> URL: https://issues.apache.org/jira/browse/YARN-6517
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Labels: findbugs
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: YARN-6517.001.patch, YARN-6517.002.patch, YARN-6517.003.patch
>
>
> There are 2 findbugs warnings in hadoop-yarn-common project since switched to spotbugs,
> # Possible null pointer dereference in org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat$LogValue.getPendingLogFilesToUpload(File) due to return value of called method
> # Possible null pointer dereference in org.apache.hadoop.yarn.util.ProcfsBasedProcessTree.getProcessList() due to return value of called method
> see more in [https://builds.apache.org/job/PreCommit-HADOOP-Build/12157/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org