You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/08/30 00:16:27 UTC

[GitHub] [arrow] kou commented on a diff in pull request #34616: GH-29238 [C++][Dataset][Parquet] Support parquet modular encryption in the new Dataset API

kou commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1309469438


##########
python/CMakeLists.txt:
##########
@@ -336,6 +343,8 @@ if(PYARROW_BUILD_PARQUET_ENCRYPTION)
   else()
     message(FATAL_ERROR "You must build Arrow C++ with PARQUET_REQUIRE_ENCRYPTION=ON")
   endif()
+else()
+  set(CYTHON_COMPILE_TIME_ENV "PARQUET_ENCRYPTION_ENABLED=0")
 endif()

Review Comment:
   How about using the existing `CYTHON_FLAGS` variable instead of adding a new `CYTHON_COMPILE_TIME_ENV` variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org