You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/27 12:53:48 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
tillrohrmann opened a new pull request #12360:
URL: https://github.com/apache/flink/pull/12360
## What is the purpose of the change
Renames `cluster.io-exeuctor.pool-size` into `cluster.io-pool.size`.
Increases the default value of `cluster.io-pool.size` from `#cores` to `4 * #cores`.
Uses a cached thread pool for the io executor instead of a fixed thread pool.
This PR is based on #12264.
cc @zentol
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #12360:
URL: https://github.com/apache/flink/pull/12360#discussion_r431096427
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ClusterEntrypointUtils.java
##########
@@ -70,7 +70,7 @@ private static File deriveFlinkHomeDirectoryFromLibDirectory() {
* @return The legal io-executor pool size.
*/
public static int getPoolSize(Configuration config) {
- final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, Hardware.getNumberCPUCores());
+ final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, 4 * Hardware.getNumberCPUCores());
Review comment:
document that it is multiplied?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #12360:
URL: https://github.com/apache/flink/pull/12360#discussion_r431108340
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/ClusterEntrypointUtils.java
##########
@@ -70,7 +70,7 @@ private static File deriveFlinkHomeDirectoryFromLibDirectory() {
* @return The legal io-executor pool size.
*/
public static int getPoolSize(Configuration config) {
- final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, Hardware.getNumberCPUCores());
+ final int poolSize = config.getInteger(ClusterOptions.CLUSTER_IO_EXECUTOR_POOL_SIZE, 4 * Hardware.getNumberCPUCores());
Review comment:
Good point. Will update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634640865
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 32b04c68bda0ea1b9cb8d57fb65e90ba38e74513 (Wed May 27 12:55:37 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
}, {
"hash" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373",
"triggerID" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6128b9729f19a5123e06ae15c1f71295139203e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282)
* a268ddec70a0108db60dba2bf401919c49b73ed2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
}, {
"hash" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373",
"triggerID" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"triggerType" : "PUSH"
}, {
"hash" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2544",
"triggerID" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a268ddec70a0108db60dba2bf401919c49b73ed2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373)
* f738742d985b130dbd5aa457fe0ad86ac6a49062 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2544)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
}, {
"hash" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373",
"triggerID" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a268ddec70a0108db60dba2bf401919c49b73ed2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6128b9729f19a5123e06ae15c1f71295139203e1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
}, {
"hash" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373",
"triggerID" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"triggerType" : "PUSH"
}, {
"hash" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a268ddec70a0108db60dba2bf401919c49b73ed2 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373)
* f738742d985b130dbd5aa457fe0ad86ac6a49062 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
}, {
"hash" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2373",
"triggerID" : "a268ddec70a0108db60dba2bf401919c49b73ed2",
"triggerType" : "PUSH"
}, {
"hash" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2544",
"triggerID" : "f738742d985b130dbd5aa457fe0ad86ac6a49062",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f738742d985b130dbd5aa457fe0ad86ac6a49062 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2544)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6128b9729f19a5123e06ae15c1f71295139203e1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12360:
URL: https://github.com/apache/flink/pull/12360#issuecomment-634666626
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6128b9729f19a5123e06ae15c1f71295139203e1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6128b9729f19a5123e06ae15c1f71295139203e1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #12360: [FLINK-17970] Increase default value of cluster.io-pool.size from #cores to 4 * #cores
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #12360:
URL: https://github.com/apache/flink/pull/12360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org