[GitHub] [hudi] alexeykudinkin commented on a change in pull request #5111: [HUDI-3695]Add orc reader in HoodieBaseRelation

[GitBox <gi...@apache.org>]

alexeykudinkin commented on a change in pull request #5111:
URL: https://github.com/apache/hudi/pull/5111#discussion_r833639635



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieBaseRelation.scala
##########
@@ -295,29 +294,39 @@ object HoodieBaseRelation {
                            filters: Seq[Filter],
                            options: Map[String, String],
                            hadoopConf: Configuration): PartitionedFile => Iterator[InternalRow] = {
-    val hfileReader = createHFileReader(

Review comment:
       The reason why it was called here as opposed to call w/in the returned lambda -- is to avoid serialization of all these passed in parameters down to Spark executor. This is likely the reason why your build is failing at the moment.
   
   Let's keep it as is, and please add a comment elaborating why this should be done in here (and executed w/in Spark Driver)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org