You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "dsmmcken (via GitHub)" <gi...@apache.org> on 2023/11/15 16:44:25 UTC
[PR] MINOR: Sort powered by page output alphabetically [kafka-site]
dsmmcken opened a new pull request, #567:
URL: https://github.com/apache/kafka-site/pull/567
I've tried to leave this page better than how I found it:
- For fairness, output is sorted alphabetically by root domain. The listing was quasi alphabetical, but looks like over time people have prepended and appended new companies into a now random order. Rather than re-sorting it once, and committing I've sorted the output by root domain (ie. eng.uber.com appears under U) such that list will always remain fair and orderly.
- A few logos had an excessively large file size. Anything over 100kb has been resized, removing 1.5mb of page weight with no loss in quality as re-sized image are still 2x the displayed size.
- Fixed a trailing space
- Added Deephaven to the list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "dsmmcken (via GitHub)" <gi...@apache.org>.
dsmmcken commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463920841
##########
powered-by.html:
##########
@@ -808,6 +813,22 @@ <h3>Want to appear on this page?</h3>
<script>
$(function () {
+ // enforce alphabetical sort by root domain for fairness
Review Comment:
I looked at the list as being mostly alphabetical and accepted that as being the original intent. Would random order upset any search bots?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463926267
##########
powered-by.html:
##########
@@ -808,6 +813,22 @@ <h3>Want to appear on this page?</h3>
<script>
$(function () {
+ // enforce alphabetical sort by root domain for fairness
Review Comment:
That's fair. Perhaps this could be a separate discussion from this PR. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "dsmmcken (via GitHub)" <gi...@apache.org>.
dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906805845
Yeah, for some reason GitHub shows the sizes relative to the other one. So since the original was 7826px (!!), the new one at 320px looks tiny in the PR review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "dsmmcken (via GitHub)" <gi...@apache.org>.
dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906929519
Thanks! FYI I don't have write access, so please merge if you are able.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #567:
URL: https://github.com/apache/kafka-site/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906795135
The Cisco and Allegrograph images seem really tiny, but maybe they look ok on the page? Can you share a screenshot of the example? I can also pull this and run the pr code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "dsmmcken (via GitHub)" <gi...@apache.org>.
dsmmcken commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906769939
Anyone available to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463915381
##########
powered-by.html:
##########
@@ -808,6 +813,22 @@ <h3>Want to appear on this page?</h3>
<script>
$(function () {
+ // enforce alphabetical sort by root domain for fairness
Review Comment:
I wonder if we are running this once per page load anyway if it is fair to randomize the logos.
That could be considered more fair. Not sure if folks expect the same ordering on reload. I guess it could be hard to find a specific logo without searching directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #567:
URL: https://github.com/apache/kafka-site/pull/567#issuecomment-1906803674


OK -- seems fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Sort powered by page output alphabetically [kafka-site]
Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #567:
URL: https://github.com/apache/kafka-site/pull/567#discussion_r1463915381
##########
powered-by.html:
##########
@@ -808,6 +813,22 @@ <h3>Want to appear on this page?</h3>
<script>
$(function () {
+ // enforce alphabetical sort by root domain for fairness
Review Comment:
I wonder if we are running this once per page load anyway if it is fair to randomize the logos.
That could be considered more fair. Not sure if folks expect the same ordering on reload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org