You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by lh...@apache.org on 2025/02/19 10:09:59 UTC
(pulsar) 02/03: [improve][meta] Simplify getting parent path in ZKMetadataStore without using java.io.File (#23996)
This is an automated email from the ASF dual-hosted git repository.
lhotari pushed a commit to branch branch-3.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit bcbbbd3b53b57ce1a922453affcf8fc88e342b5c
Author: Lari Hotari <lh...@users.noreply.github.com>
AuthorDate: Mon Feb 17 23:11:26 2025 -0800
[improve][meta] Simplify getting parent path in ZKMetadataStore without using java.io.File (#23996)
(cherry picked from commit 4bfdcd85ff5c9f21ba4fd976adf7785465053151)
---
.../main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
index 5f4798a351a..a1e0fb3ffc6 100644
--- a/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
+++ b/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
@@ -19,7 +19,6 @@
package org.apache.pulsar.metadata.impl;
import com.google.common.annotations.VisibleForTesting;
-import java.io.File;
import java.util.Collections;
import java.util.EnumSet;
import java.util.List;
@@ -604,8 +603,10 @@ public class ZKMetadataStore extends AbstractBatchedMetadataStore
if (rc != Code.NONODE.intValue()) {
callback.processResult(rc, path, ctx, name);
} else {
- String parent = (new File(originalPath)).getParent().replace("\\", "/");
-
+ String parent = parent(originalPath);
+ if (parent == null) {
+ parent = "/";
+ }
// Create parent nodes as "CONTAINER" so that ZK will automatically delete them when they're empty
asyncCreateFullPathOptimistic(zk, parent, new byte[0], CreateMode.CONTAINER,
(rc1, path1, ctx1, name1) -> {