[GitHub] [echarts] susiwen8 commented on a diff in pull request #16026: Fix(markline): markLine shouldn't be filtered if one point is out side of the grid

[GitBox <gi...@apache.org>]

susiwen8 commented on code in PR #16026:
URL: https://github.com/apache/echarts/pull/16026#discussion_r866021838


##########
src/component/marker/MarkLineView.ts:
##########
@@ -305,8 +306,13 @@ class MarkLineView extends MarkerView {
         const lineDrawMap = this.markerGroupMap;
         const lineDraw = lineDrawMap.get(seriesId)
             || lineDrawMap.set(seriesId, new LineDraw());
+        const clipPath = createClipPath(
+            (seriesModel.coordinateSystem as Cartesian2D), false, seriesModel
+        );
+        this.group.setClipPath(clipPath);

Review Comment:
   @Ovilia @pissang I'm thinking put this after `createList` which can return the array of filtered `markerLine`, if this array is empty, the we can skip `clip`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org