You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/02/26 10:29:56 UTC
[PR] Update README.md to note new JDK usage instructions [incubator-pekko-sbt-paradox]
mdedetrich opened a new pull request, #119:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/119
The current instructions are out of date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update README.md to note new JDK usage instructions [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #119:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/119#discussion_r1502405283
##########
README.md:
##########
@@ -31,23 +31,27 @@ Use the sbt plugin for Pekko Paradox:
addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "<version>")
```
-### Usage within JDK 1.8 projects
+## Usage
Review Comment:
There are 2 ##`Usage` titles in the readme (this line and line 27). Is it possible to merge the sections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update README.md to note new JDK usage instructions [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #119:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update README.md to note new JDK usage instructions [incubator-pekko-sbt-paradox]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #119:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/119#discussion_r1502408729
##########
README.md:
##########
@@ -31,23 +31,27 @@ Use the sbt plugin for Pekko Paradox:
addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "<version>")
```
-### Usage within JDK 1.8 projects
+## Usage
Review Comment:
Woops, thanks for noticing. Just rebased PR with the duplicate removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Update README.md to note new JDK usage instructions [incubator-pekko-sbt-paradox]
Posted by "samueleresca (via GitHub)" <gi...@apache.org>.
samueleresca commented on code in PR #119:
URL: https://github.com/apache/incubator-pekko-sbt-paradox/pull/119#discussion_r1502405283
##########
README.md:
##########
@@ -31,23 +31,27 @@ Use the sbt plugin for Pekko Paradox:
addSbtPlugin("org.apache.pekko" % "pekko-sbt-paradox" % "<version>")
```
-### Usage within JDK 1.8 projects
+## Usage
Review Comment:
There are 2 `##Usage` titles in the readme (this line and line 27). Is it possible to merge the sections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org