You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org> on 2024/07/17 13:36:16 UTC
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Myktybek Sattarov has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21591
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct error message when it encounters a table that contains a parquet file with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
3 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/2
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 2
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 2:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py
File tests/query_test/test_parquet_encodings.py:
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@21
PS2, Line 21: class TestParquetEncodings(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@31
PS2, Line 31:
flake8: W293 blank line contains whitespace
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@31
PS2, Line 31:
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@33
PS2, Line 33: _
flake8: E501 line too long (137 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@36
PS2, Line 36: _
flake8: E501 line too long (139 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@40
PS2, Line 40: +
flake8: E501 line too long (115 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@43
PS2, Line 43: ,
flake8: E231 missing whitespace after ','
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@43
PS2, Line 43: i
flake8: E501 line too long (124 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/2/tests/query_test/test_parquet_encodings.py@45
PS2, Line 45:
flake8: W292 no newline at end of file
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 2
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 13:37:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct
error message when it encounters a table that contains a parquet file
with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/README
A testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
5 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/12
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 12
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 11:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16552/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 11
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 13:27:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21591/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21591/6//COMMIT_MSG@9
PS6, Line 9: This commit adds an EE test that checks that Impala returns the correct error message when it encounters a table that contains a parquet file with Byte Stream Split encoding.
Lines should be at most 72 characters in the commit message.
http://gerrit.cloudera.org:8080/#/c/21591/6/testdata/parquet_byte_stream_split_encoding/test_double.parquet
File testdata/parquet_byte_stream_split_encoding/test_double.parquet:
http://gerrit.cloudera.org:8080/#/c/21591/6/testdata/parquet_byte_stream_split_encoding/test_double.parquet@1
PS6, Line 1: PAR1 , %æ²f i@%æ²f i@ (%æ²f i@%æ²f i@ 4 %æ²f i@&¢
We should add a README file in testdata/parquet_byte_stream_split_encoding that describes how these two parquet files were generated. See for example https://github.com/apache/impala/blob/master/testdata/parquet_nested_types_encodings/README
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 6
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:32:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21591/4/tests/query_test/test_parquet_encodings.py
File tests/query_test/test_parquet_encodings.py:
http://gerrit.cloudera.org:8080/#/c/21591/4/tests/query_test/test_parquet_encodings.py@21
PS4, Line 21: class TestParquetEncodings(ImpalaTestSuite):
flake8: E302 expected 2 blank lines, found 1
http://gerrit.cloudera.org:8080/#/c/21591/4/tests/query_test/test_parquet_encodings.py@38
PS4, Line 38:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/4/tests/query_test/test_parquet_encodings.py@38
PS4, Line 38: self.byte_stream_split_helper(vector, unique_database,
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 4
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 13:57:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct
error message when it encounters a table that contains a parquet file
with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/README
A testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
5 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/11
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 11
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 10:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16551/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 10
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 13:25:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has abandoned this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 12
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct
error message when it encounters a table that contains a parquet file
with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/README
A testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
5 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/10
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 10
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 10:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/21591/10/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py:
http://gerrit.cloudera.org:8080/#/c/21591/10/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@9
PS10, Line 9:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/10/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@9
PS10, Line 9: pq.write_table(float_table, file_path + 'test_float.parquet',
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 10
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 13:00:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 4:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16531/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 4
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 14:23:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 9:
(16 comments)
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py
File testdata/parquet_byte_stream_split_encoding/fileGenerator.py:
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@7
PS9, Line 7: e
flake8: E501 line too long (94 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@8
PS9, Line 8:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@8
PS9, Line 8: use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@13
PS9, Line 13: q
flake8: E501 line too long (96 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@14
PS9, Line 14:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py:
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS9, Line 5:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS9, Line 5:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7: r
flake8: E501 line too long (128 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7: pq.write_table(float_table, '/home/sattarov/repos/pyArrow/test_float.parquet', use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS9, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS9, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12: s
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12: pq.write_table(double_table, '/home/sattarov/repos/pyArrow/test_double.parquet', use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 9
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 12:15:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct
error message when it encounters a table that contains a parquet file
with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/README
A testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
5 files changed, 81 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/8
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 8
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16530/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 2
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 14:01:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 6:
(3 comments)
Nice patch Myktybek, I left some nits.
http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py
File tests/query_test/test_parquet_encodings.py:
http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@16
PS6, Line 16: # under the License.
nit: add spacing between license and imports
http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@43
PS6, Line 43: def byte_stream_split_helper(self, vector, unique_database, file_name, column_def):
nit: we usually prefix helper functions with underscore (_)
http://gerrit.cloudera.org:8080/#/c/21591/6/tests/query_test/test_parquet_encodings.py@46
PS6, Line 46: unique_database + "." + table_name
it could be extracted, or table_name could be formatted with unique_database, like `table_name = "{}.{}".format(unique_database, "test_table")`
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 6
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 08:46:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 5:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16532/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 5
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 14:24:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16553/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 12
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 15:37:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct error message when it encounters a table that contains a parquet file with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
3 files changed, 50 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/4
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 4
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct error message when it encounters a table that contains a parquet file with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
3 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/6
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 6
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16533/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 6
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 14:33:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 12:
(2 comments)
Some more nits.
http://gerrit.cloudera.org:8080/#/c/21591/12/testdata/parquet_byte_stream_split_encoding/README
File testdata/parquet_byte_stream_split_encoding/README:
http://gerrit.cloudera.org:8080/#/c/21591/12/testdata/parquet_byte_stream_split_encoding/README@12
PS12, Line 12: file
"python script" would be better.
http://gerrit.cloudera.org:8080/#/c/21591/12/testdata/parquet_byte_stream_split_encoding/README@14
PS12, Line 14: about the Parquet
"about PyArrow", not Parquet.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 12
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2024 13:37:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct
error message when it encounters a table that contains a parquet file
with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/README
A testdata/parquet_byte_stream_split_encoding/fileGenerator.py
A testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
6 files changed, 95 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/9
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 9
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 8:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py:
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS8, Line 5:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS8, Line 5:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS8, Line 7: r
flake8: E501 line too long (128 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS8, Line 7:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS8, Line 7: pq.write_table(float_table, '/home/sattarov/repos/pyArrow/test_float.parquet', use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS8, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS8, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS8, Line 12: s
flake8: E501 line too long (130 > 90 characters)
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS8, Line 12:
flake8: W291 trailing whitespace
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS8, Line 12:
flake8: W292 no newline at end of file
http://gerrit.cloudera.org:8080/#/c/21591/8/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS8, Line 12: pq.write_table(double_table, '/home/sattarov/repos/pyArrow/test_double.parquet', use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 8
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 12:08:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 8:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16549/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 8
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 12:32:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
Patch Set 9:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/16550/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 9
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 12:39:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
Posted by "Myktybek Sattarov (Code Review)" <ge...@cloudera.org>.
Myktybek Sattarov has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21591 )
Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
......................................................................
IMPALA-13211: Add negative test for Parquet Byte Stream Split encoding
This commit adds an EE test that checks that Impala returns the correct error message when it encounters a table that contains a parquet file with Byte Stream Split encoding.
Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
---
A testdata/parquet_byte_stream_split_encoding/test_double.parquet
A testdata/parquet_byte_stream_split_encoding/test_float.parquet
A tests/query_test/test_parquet_encodings.py
3 files changed, 51 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/21591/5
--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 5
Gerrit-Owner: Myktybek Sattarov <sa...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>