You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/12 09:44:25 UTC
[GitHub] [maven-indexer] cstamas opened a new pull request #176: Update release plugin
cstamas opened a new pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176
As it causes havoc while releasing 6.1.0
but parent is not yet released, so put
yet-another TODO into POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas merged pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas merged pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
cstamas merged pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] pzygielo commented on a change in pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176#discussion_r805143110
##########
File path: pom.xml
##########
@@ -374,6 +374,11 @@ under the License.
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
+ <plugin><!-- TODO remove when upgrading parnet POM to 35 -->
Review comment:
Could _parnet_ here and above be fixed, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a change in pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176#discussion_r805145561
##########
File path: pom.xml
##########
@@ -369,11 +369,16 @@ under the License.
</plugins>
<pluginManagement>
<plugins>
- <plugin><!-- TODO remove when upgrading parnet POM to 35 -->
+ <plugin><!-- TODO remove when upgrading parent POM to 35 -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
+ <plugin><!-- TODO remove when upgrading parent POM to 35 -->
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] pzygielo commented on a change in pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
pzygielo commented on a change in pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176#discussion_r805145213
##########
File path: pom.xml
##########
@@ -369,11 +369,16 @@ under the License.
</plugins>
<pluginManagement>
<plugins>
- <plugin><!-- TODO remove when upgrading parnet POM to 35 -->
+ <plugin><!-- TODO remove when upgrading parent POM to 35 -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
+ <plugin><!-- TODO remove when upgrading parent POM to 35 -->
Review comment:
As there is chance that on parent upgrade this removal will not be enforced - thus perhaps line 26 deserves comment to do TODOs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-indexer] cstamas commented on a change in pull request #176: Update release plugin
Posted by GitBox <gi...@apache.org>.
cstamas commented on a change in pull request #176:
URL: https://github.com/apache/maven-indexer/pull/176#discussion_r805143646
##########
File path: pom.xml
##########
@@ -374,6 +374,11 @@ under the License.
<artifactId>maven-shade-plugin</artifactId>
<version>3.2.4</version>
</plugin>
+ <plugin><!-- TODO remove when upgrading parnet POM to 35 -->
Review comment:
fixed, tx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org