[GitHub] [cloudstack] sureshanaparti commented on pull request #4774: Added configuration and Integration test to restrict public template …

[GitBox <gi...@apache.org>]

sureshanaparti commented on PR #4774:
URL: https://github.com/apache/cloudstack/pull/4774#issuecomment-1092803383

   > Hi @nvazquez, I'm waiting for @sureshanaparti to test and approve the changes. We had a long discussion about what is the correct behavior. They have started [here](https://github.com/apache/cloudstack/pull/4774#issuecomment-932060180).
   > 
   > Will update the test after that as soon as I get his approval.
   > 
   > > Continued tests with domain level setting.
   > > (i)
   > > 
   > > * Domain1 config "restrict.public.template.access.to.domain": false and Domain2 config "restrict.public.template.access.to.domain": true
   > >   => The public templates of domain1 are not listed for domain2 admin.
   > >   => The public templates of domain2 are listed for domain1 admin.
   > > 
   > > (ii)
   > > 
   > > * Domain1 config "restrict.public.template.access.to.domain": true and Domain2 config "restrict.public.template.access.to.domain": false
   > >   => The public templates of domain1 are listed for domain2 admin.
   > >   => The public templates of domain2 are not listed for domain1 admin.
   > > 
   > > (iii)
   > > 
   > > * Set the Domain1 config "restrict.public.template.access.to.domain": false and Domain2 config "restrict.public.template.access.to.domain": false
   > >   => The public templates of domain1 are listed for domain2 admin
   > >   => The public templates of domain2 are listed for domain1 admin
   > > 
   > > (iv)
   > > 
   > > * Set the Domain1 config "restrict.public.template.access.to.domain": true and Domain2 config "restrict.public.template.access.to.domain": true
   > >   => The public templates of domain1 are not listed for domain2 admin
   > >   => The public templates of domain2 are not listed for domain1 admin
   > > 
   > > @soreana tests (i) and (ii) above, should list the public templates when the respective domain config ""restrict.public.template.access.to.domain" is false, and it seems to be working in the other way. Please check.
   
   @nvazquez @soreana will test this and update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org