You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/13 17:44:23 UTC
[GitHub] [tvm] comaniac commented on a change in pull request #8995: [Autoscheduler] Reduce task weight coercion overhead
comaniac commented on a change in pull request #8995:
URL: https://github.com/apache/tvm/pull/8995#discussion_r707551632
##########
File path: src/node/reflection.cc
##########
@@ -106,8 +106,12 @@ runtime::TVMRetValue ReflectionVTable::GetAttr(Object* self, const String& field
}
}
if (!success) {
- LOG(FATAL) << "AttributeError: " << self->GetTypeKey() << " object has no attributed "
- << getter.skey;
Review comment:
I agree that LOG(FATAL) would be more debug-friendly, but I'm not sure if it is practical to fix where ever is calling GetAttr in an inefficient way, as GetAttr is used basically every where. IMHO, it doesn't hurt to make an exception use (i.e., `throw`) for this special case. Meanwhile, if we want to keep LOG(FATAL) for debugging purpose, we may consider using a macro or DLOG(FATAL).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org