You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/24 16:25:05 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
codelipenghui opened a new pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656
### Motivation
Fix deduplication cursor does not delete after disabling message deduplication. The issue occurs when enabling the message deduplication at the broker.conf and then disable it and restart the broker. The dedup cursor will not be deleted.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: ( no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-664095135
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-665358703
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-663776882
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy edited a comment on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
wolfstudy edited a comment on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-665067132
@codelipenghui Please check the test case, thanks
```
[ERROR] testAckCommand(org.apache.pulsar.broker.service.ServerCnxTest) Time elapsed: 10.148 s <<< FAILURE!
java.io.IOException: Failed to get response from socket within 10s
at org.apache.pulsar.broker.service.ServerCnxTest.getResponse(ServerCnxTest.java:1459)
at org.apache.pulsar.broker.service.ServerCnxTest.testAckCommand(ServerCnxTest.java:1250)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
at org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-663621742
related to #7345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #7656: Fix deduplication cursor does not delete after disabling message deduplication
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #7656:
URL: https://github.com/apache/pulsar/pull/7656#issuecomment-664795750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org