You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/09/07 01:39:52 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42745: [SPARK-45027][PYTHON] Hide internal functions/variables in `pyspark.sql.functions` from auto-completion

HyukjinKwon commented on code in PR #42745:
URL: https://github.com/apache/spark/pull/42745#discussion_r1317991376


##########
python/pyspark/sql/utils.py:
##########
@@ -179,7 +179,7 @@ def is_remote() -> bool:
     return "SPARK_CONNECT_MODE_ENABLED" in os.environ
 
 
-def try_remote_functions(f: FuncT) -> FuncT:

Review Comment:
   you could just leave this as is, and fix `functions.py` when you import with an alias. e.g., `from pyspark.sql.utils import try_remote_functions as _try_remote_functions`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org