You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ScrapCodes <gi...@git.apache.org> on 2015/12/09 10:28:50 UTC
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/spark/pull/10223
[SPARK-12238][STREAMING][DOCS] s/Advanced Sources/External Sources in docs.
While reading the streaming docs, I felt reading as external sources(instead of Advanced sources) seemed more appropriate as they belong outside streaming core project.
@tdas I am sure you must have thought well about this. You may even have a better suggestion for this.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/spark streaming-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10223.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10223
----
commit 3d432b943a21d29c958824b27b95ff57a3e1d01d
Author: Prashant Sharma <sc...@gmail.com>
Date: 2015-12-09T09:21:57Z
[SPARK-12238][STREAMING][DOCS] s/Advanced sources/External Sources in docs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163166744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47423/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163273324
I'm not sure 'external' is accurate; sockets are connections to an external system too; one might consider a flume agent 'internal'. IMHO it's no better than the original text.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163166743
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163606752
hm.. I will think more.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163166615
**[Test build #47423 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47423/consoleFull)** for PR 10223 at commit [`3d432b9`](https://github.com/apache/spark/commit/3d432b943a21d29c958824b27b95ff57a3e1d01d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10223#issuecomment-163164284
**[Test build #47423 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47423/consoleFull)** for PR 10223 at commit [`3d432b9`](https://github.com/apache/spark/commit/3d432b943a21d29c958824b27b95ff57a3e1d01d).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12238][STREAMING][DOCS] s/Advanced Sour...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes closed the pull request at:
https://github.com/apache/spark/pull/10223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org