You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/28 15:45:33 UTC
[GitHub] [incubator-mxnet] litaotju opened a new pull request #17189: Minor
fix, use RAII for TensorRT builder and network object
litaotju opened a new pull request #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17189: Minor fix,
use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-572407090
Hi @ptrendx , could you please help take a review? Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju commented on issue #17189: Minor fix,
use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
litaotju commented on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-569910456
@szha , this is my first commit to this one. Trying to get myself familiar with the project by minor fix.
Found I can not request review for this? Do you know what's the proper process for review on such fix?
(I Saw you name in serveral reviews, so at you here. Hope you don't mind). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju removed a comment on issue #17189: Minor
fix, use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
litaotju removed a comment on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-569433081
@mxnet-label-bot "CUDA"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn merged pull request #17189: Minor fix,
use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
wkcn merged pull request #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju edited a comment on issue #17189: Minor
fix, use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
litaotju edited a comment on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-569910456
@szha , this is my first commit to this project. Trying to get myself familiar with the project by minor fix. Found I can not request review for this. Do you know what's the proper process for review on such fix? How do I specify reviewers?
(I Saw you name in serveral reviews, so trying to find your help here. Hope you don't mind). Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] litaotju commented on issue #17189: Minor fix,
use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
litaotju commented on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-569433081
@mxnet-label-bot "CUDA"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] wkcn commented on issue #17189: Minor fix,
use RAII for TensorRT builder and network object
Posted by GitBox <gi...@apache.org>.
wkcn commented on issue #17189: Minor fix, use RAII for TensorRT builder and network object
URL: https://github.com/apache/incubator-mxnet/pull/17189#issuecomment-573088471
Merged. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services